Plots2: Subscribing to already subscribed tag shows wrong alert

Created on 20 Apr 2019  ·  11Comments  ·  Source: publiclab/plots2

When a user subscribe to the tag which already exists, the alert message says the "you are now following ###" instead it should say that "you have already subscribed to the tag".

Screen Shot 2019-04-20 at 5 12 14 PM

CSS HTML Ruby bug testing

All 11 comments

Hi, Is somebody working on it? I would like to contribute , I`m new in open source contributions 👍 @gautamig54

Go ahead @ValeriaCobianISW !!

@ValeriaCobianISW I am already working on this issue. I will ask for your help if need be. Thanks for checking in this.

@ValeriaCobianISW You can work on #5554 to begin with. Thanks!

Oh! if @gautamig54 is working on this. Here's is the list of fto https://github.com/publiclab/plots2/issues?q=is%3Aopen+is%3Aissue+label%3Afto-candidate. You can check this out.

Oh! Thanks, I´m going to check that, thank you @gautamig54 @namangupta01 😄

@IshaGupta18 codebase for subscriptions page is not in the repo I think. How can I go about making this change?

Hey! Let me look into it and ill get back to you!

On Sun, Apr 21, 2019, 2:32 PM Gautami Gupta notifications@github.com
wrote:

@IshaGupta18 https://github.com/IshaGupta18 codebase for subscriptions
page is not in the repo I think. How can I go about making this change?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5556#issuecomment-485236473,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJXHQZ7LF3ROKRGO7O5VHP3PRQUTTANCNFSM4HHJQJUA
.

I think this is the one, do correct me if I am wrong!

Please add a test too, if possible. Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

keshavsethi picture keshavsethi  ·  3Comments

milaaraujo picture milaaraujo  ·  3Comments

grvsachdeva picture grvsachdeva  ·  3Comments

jywarren picture jywarren  ·  3Comments

first-timers[bot] picture first-timers[bot]  ·  3Comments