Plots2: Error page when entering wrong password, then right password

[jywarren]

When I enter the wrong password from any page's Login modal, i get a 'wrong password' message, which is good.

But then I enter the right one, and i see an error page!

[VegChick2]

Can I work on this?

[gautamig54]

I think this issue arises because there is no index action defined in the user-sessions controller.
It can be solved by creating an index function in user-sessions controller and directing the user to the dashboard from here.
What do you think about this @jywarren ?

[gautamig54]

@40404notfound What are your thoughts on this? It will be great to have your opinion as well!

[jywarren]

That sounds like a great solution; where do you see it directing to an
index action? Thanks!!!

On Sun, Apr 7, 2019 at 5:06 PM Gautami Gupta [e-mail]
wrote:

@40404notfound https://github.com/40404notfound What are your thoughts
on this? It will be great to have your opinion as well!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5405#issuecomment-480629662,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxLajkx5Cc_1aURwufEB_x_3pvD7ks5vel20gaJpZM4cg-iH
.

[gautamig54]

When I do the same procedure of first entering the wrong password and then entering the right one in my local system, it shows an error that index action is not defined in User-sessions controller.
I would like to work on this bug. Thanks!

[VegChick2]

@gautamig54 Hi, I discovered the same issue. I am quite new to this project and I am still learning the project organization. I would love to help in solving this issue.
Can I have a chance to fix this? Thanks!!

[gautamig54]

Sure! Go ahead with this. Do ask if you are stuck anywhere :)
Welcome to Public Lab and hope to see many contributions from you!

[VegChick2]

@jywarren @gautamig54
Hi, I followed @gautamig54 's suggestion and make the pull request. Looks like the issue is gone now! Thanks a lot for @gautamig54's great hint!

[jywarren]

oh awesome! Can you link us to your PR from here? Thanks so much for your
help!

On Mon, Apr 8, 2019 at 9:46 AM 40404notfound [e-mail]
wrote:

@jywarren https://github.com/jywarren @gautamig54
https://github.com/gautamig54
Hi, I followed @gautamig54 https://github.com/gautamig54 's suggestion
and makes the pull request. Looks like the issue is gone now! Thanks a lot
for @gautamig54 https://github.com/gautamig54's great hint!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5405#issuecomment-480838035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ4CipoOKpxE6gGsYozZEBIcqM5tLks5ve0gIgaJpZM4cg-iH
.

[VegChick2]

@jywarren Sure, here you go! https://github.com/publiclab/plots2/pull/5410