Plots2: traceback of error from server is shown in webpage

[CleverFool77]

Description

While working on the issue https://github.com/publiclab/plots2/issues/5327
I found this.
It showed the traceback of error from server on the webpage. And after I refreshed it, the tag was added.
The gif shows the steps to reproduce it -

[CleverFool77]

@publiclab/plots2-reviewers What's your opinion regarding this issue ?

[jywarren]

Ah, i think this is where it's trying to fetch the result of an AJAX
request to add a tag, and displaying the response inline --

https://github.com/publiclab/plots2/blob/master/app/views/tag/_tagging.html.erb

It's supposed to catch errors here, but it seems it's not doing so...
https://github.com/publiclab/plots2/blob/c97968aa6bce38dbb2d66548ee05cae0dc4cdc23/app/assets/javascripts/tagging.js#L63-L68

So, something is going wrong in the error, and it's getting inserted into
the page here:
https://github.com/publiclab/plots2/blob/c97968aa6bce38dbb2d66548ee05cae0dc4cdc23/app/assets/javascripts/tagging.js#L41-L54

This is a great candidate for a system test!
https://github.com/publiclab/plots2/issues/5316

Thanks for catching this, @CleverFool77!

On Fri, Apr 5, 2019 at 12:39 PM Lekhika Dugtal [e-mail]
wrote:

@publiclab/plots2-reviewers
https://github.com/orgs/publiclab/teams/plots2-reviewers What's your
opinion regarding this issue ?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5378#issuecomment-480342421,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ9NVa4zdqUyistKazaw_OS_1PtRVks5vd3wugaJpZM4cfT6Y
.

[CleverFool77]

Hi @jywarren I would like to. Fix this issue.

[grvsachdeva]

Great!