Plots2: Refactor answers_controller with simpler user role check

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/controllers/answers_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -30,10 +30,7 @@ def update
   end

   def delete
-    if current_user.uid == @answer.node.uid ||
-       @answer.uid == current_user.uid ||
-       current_user.role == 'admin' ||
-       current_user.role == 'moderator'
+    if current_user.uid == @answer.node.uid || @answer.uid == current_user.uid || logged_in_as(['admin', 'moderator'])
       respond_to do |format|
         if @answer.destroy
           format.html { redirect_to @answer.node.path(:question), notice: 'Answer deleted' }
@@ -49,7 +46,7 @@ def delete
   end

   def accept
-    if current_user.role == "admin" || current_user.role == "moderator" || current_user.uid == @answer.node.uid
+    if logged_in_as(['admin', 'moderator']) || current_user.uid == @answer.node.uid
       respond_to do |format|
         if @answer.accepted
           @answer.accepted = false

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

[grvsachdeva]

This issue is created for @dimpho0101. Thanks!

[dimpho0101]

Thank you :) @gauravano I am starting to work on it now

[grvsachdeva]

Great :+1:

On Tue, Apr 2, 2019 at 8:00 PM Dimpho Jessica Putu [e-mail]
wrote:

Thank you :) @gauravano https://github.com/gauravano I am starting to
work on it now

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5346#issuecomment-479023566,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT6S9hsGbbI7JuOH9EypFbk6e5h9Qsttks5vc2lwgaJpZM4cYKD5
.

[AnshitaVishwa]

@gauravano i would like to work on this issue. I am new to public lab.

[ananyaarun]

@dimpho0101 are you still working on this issue :) ?
Else @AnshitaVishwa can take it up.
Do let us know.
Thanks :)

[AnshitaVishwa]

@ananyaarun shoud i start working on it?

[ananyaarun]

@AnshitaVishwa sure go ahead :)

[AnshitaVishwa]

@ananyaarun the changes that are required to be done are already done in the file. But still this issue isn't closed.

[ananyaarun]

@AnshitaVishwa Yes you are correct. Thanks !!
You can work on any new comer issue in this LEL repository :) https://github.com/publiclab/leaflet-environmental-layers/issues/189
@gauravano I think this issue has been solved in another PR and can be closed.

[grvsachdeva]

Sorry, @AnshitaVishwa. Looks like another contributor changed the statement for all the files - https://github.com/publiclab/plots2/pull/5660. As @ananyaarun mentioned, please have a look at other FTO issues. Thanks!

Thanks, @ananyaarun for notifying!