Plots2: Wiki index ordering

[grvsachdeva]

Our wiki page (https://publiclab.org/wiki) has various sorting options but not all of them work well. So, we need help with fixing this page.

Also, I think we can do some fix to the design of the page too, not major changes but some minor fixes like controlling width. etc so the column headings don
t take another row.

Only edits and likes sorting is working fine and other options need to be fixed.

Here's the controller method: https://github.com/publiclab/plots2/blob/master/app/controllers/wiki_controller.rb#L299-L324

And, here the view file: https://github.com/publiclab/plots2/blob/master/app/views/wiki/index.html.erb

[GettyOrawo]

Hey @gauravano . Need help with this? Would love to take it up

[grvsachdeva]

That would be great @GettyOrawo!

[GettyOrawo]

:smile: Alright, on it. I'll update on my progress,

[ananyaarun]

@gauravano , there is something wrong with the ordering of notes and wikis as pointed out.
I found these bugs too https://github.com/publiclab/plots2/issues/5170
https://github.com/publiclab/plots2/issues/5076
and while fixing them i observed some inconsistencies in their codes especially wrt acs and desc order for both wikis and notes. It seems to work the reverse way of what is expected.
Here is the PR for reference https://github.com/publiclab/plots2/pull/5088

Could this be related somehow ? since i see the same approach in code for sorting notes and wikis accordingly.

[GettyOrawo]

@ananyaarun thanks! From the referenced issues, those were mostly targeting the notes section, specifically code in the notes_controller.rb but this particular one is for the wikis page https://publiclab.org/wiki targeting the wikis_controller.rb

Yes the approach could be the same though when it comes to the sorting bug.

[GettyOrawo]

Then @gauravano I was wondering for the design being enhanced a little, do we actually need the wiki url besides the wiki title yet when you click on the wiki title it takes you to the same url.. maybe we could do away with the url column which will in turn create enough room for the other column titles not to spill to the next line. What do you think?

like this..

[jywarren]

I think this is a good idea!!

On Mon, Apr 1, 2019 at 4:38 AM GettyOrawo [e-mail] wrote:

Then @gauravano https://github.com/gauravano I was wondering for the
design being enhanced a little, do we actually need the wiki url besides
the wiki title yet when you click on the wiki title it takes you to the
same url.. maybe we could do away with the url column which will in turn
create enough room for the other column titles not to spill to the next
line. What do you think?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5317#issuecomment-478488226,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJwIatwg4SdAmPb3Z14KFiJX0m-X9ks5vccVcgaJpZM4cUL3Y
.

[GettyOrawo]

It's interesting that the project uses Drupal. What is the main reason for this @jywarren or @gauravano ? I personally haven't worked with Drupal before.

[GettyOrawo]

The PR is up would love your reviews. Thanks. #5326 :tada:

[alonpeer]

Ordering by views count will get fixed once these PRs are merged: #5338 and #5307.

[alonpeer]

@GettyOrawo I don't have a lot of context on the Drupal choice, however the README says:

Originally a Drupal site, it was rewritten in 2012 in Ruby on Rails and has since extended but not entirely replaced the legacy Drupal data model and database design.

So this was originally a Drupal project, and the DB schema was kept when it was rewritten in Rails. AFAIK there's no more Drupal code around (which makes sense, since it's PHP, and probably hard to run in parallel to Ruby).

[jywarren]

Thanks, i'll check out these PRs today! Sorry to be slow!

Regarding Drupal, yes, there are just a few leftover traces of Drupal in
our database table names and a few other bits and pieces. We're still
working to remove and simplify them all! We have an overall planning issue
for this here: https://github.com/publiclab/plots2/issues/956

And a couple individual projects towards this goal here and here:
https://github.com/publiclab/plots2/issues/4074,
https://github.com/publiclab/plots2/issues/76

We'd love help with those too! Thanks all!

On Tue, Apr 2, 2019 at 3:23 AM GettyOrawo [e-mail] wrote:

It's interesting that the project uses Drupal. What is the main reason for
this @jywarren https://github.com/jywarren or @gauravano
https://github.com/gauravano ? I personally haven't worked with Drupal
before.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5317#issuecomment-478876519,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ-uHam1F28neqlwALS_ZTI8n6nC6ks5vcwVsgaJpZM4cUL3Y
.

[GettyOrawo]

oh yes, makes sense now.. Thank you.