Plots2: Implement shortcut key to change focus over searchbar

[CleverFool77]

Description

Currently, The users need to take the cursor to search bar and then type and enter it. Instead user can directly use shortcut key to change focus over to the search bar. And then type.
Thus, removing the requirement of mouse for while searching.

[CleverFool77]

@publiclab/reviewers Is this issue correct ?

[CleverFool77]

If approved, then I would like to work on this.
thanks :).

[harshkhandeparkar]

Browsers have many other shortcut keys. Which one would you use here which would not conflict with the browser or the system(os)?

[CleverFool77]

How about ctrl+shift+f @HarshKhandeparkar . It's not used anywhere.

[CleverFool77]

alt is reserved by different OS'es in different way and shift isn't used much.
So this could be most preferred one.

[CleverFool77]

I wanted to ask if overriding keys is available ?

[harshkhandeparkar]

Is typing alt+shift+f easy? Can it be done with 3 fingers of the same hand?

[CleverFool77]

@HarshKhandeparkar Using alt for shortcut keys isn't preferred as different OS reserve alt shortcut keys in their own way hence it might be possible some users wont be able to use the search shortcut key. Using ctrl+shift+f looks good to me and it is well withing comfort of pressing with same hand.
We might have considered using ctrl+shift+s but it is the shortcut key to open debugger menu in firefox.
Ctrl+shift+f seems an appropriate choice as ctrl+f is used for find and to convey search within public lab, we can use ctrl+shift+f.

[harshkhandeparkar]

I guess opera uses it for in-built search.
You can check here https://defkey.com/what-means/ctrl-shift-f

[CleverFool77]

@HarshKhandeparkar How about overriding the keys ?

[harshkhandeparkar]

I don't think that is possible.

[harshkhandeparkar]

Also how will you implement this? Using JavaScript?

[CleverFool77]

@HarshKhandeparkar yes, overriding shortcut keys via javascript is completely possible.

[harshkhandeparkar]

Then it's ok i think. Just ask @publiclab/plots2-reviewers first though.

[CleverFool77]

@HarshKhandeparkar The applications like facebook,twitter,gmail, slack, zulip etc. override the in browser keys like ctrl+s with their in application shortcut keys to provide a better user experience.
And considering publiclab has notes ,blog ,subscribe and many more features. This would be very helpful in future course.

[grvsachdeva]

I think it's a good idea. @publiclab/community-reps what do you think?

[jywarren]

Sure -- in Gmail and other apps, the '/' key opens search. We could do
that? Try this code to detect a keystroke:

$(window).on('keypress', function(e){console.log("keyCode is: " +
e.keyCode)})

On Tue, Mar 19, 2019 at 5:22 AM Lekhika Dugtal [e-mail]
wrote:

@publiclab/reviewers https://github.com/orgs/publiclab/teams/reviewers
Is this issue correct ?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5174#issuecomment-474261027,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ17fxuKYXIf1JQXgXgVKdlScTKNcks5vYKxAgaJpZM4b7oji
.