Plots2: Center align the question form

[ananyaarun]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file questionRich.html.erb
  in the plots2 repository to add CSS to center align the form.
  Code of this form can be added to the div.
  <div align="center">

See this page for some help in taking your first steps!

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

[ananyaarun]

@publiclab/plots2-reviewers , Maybe this can make a good FTO for a newcomer.

[grvsachdeva]

Could you check @ananyaarun if this change will affect other views like /post, /post?template=event , etc or not. As while creating research note we show instructions on the left side so this change may look good on the questions page but not /post?

[ananyaarun]

Sure @gauravano , I'll test it and get bk to u.

[grvsachdeva]

Great!

On Mon, Mar 18, 2019 at 8:28 PM Ananya Arun [e-mail]
wrote:

Sure @gauravano https://github.com/gauravano , I'll test it and get bk
to u.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5150#issuecomment-473945793,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT6S9uEBMyDwpTKn7qIg12br0p0qSCh7ks5vX6mggaJpZM4b5m8v
.

[ananyaarun]

@gauravano , U were right its due to missing instructions in this case that the page looks right aligned. center aligning it would affect the other pages. We could add the same kind of instructions here then maybe ?

[grvsachdeva]

Are those instructions relevant to other pages?

On Thu, Mar 21, 2019 at 9:08 PM Ananya Arun [e-mail]
wrote:

@gauravano https://github.com/gauravano , U were right its due to
missing instructions in this case that the page looks right aligned. center
aligning it would affect the other pages. We could add the same kind of
instructions here then maybe ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5150#issuecomment-475281536,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT6S9gsKSwZ2-1zEqw7-JU3uvZGShwiLks5vY6d-gaJpZM4b5m8v
.

[ananyaarun]

The thing is /post etc follow some steps so adding instructions here is helpful.

I'm not so sure what instruction can be added here since its just title followed by text description.
Or can we just add step1 - add title step 2- content description in this case ?
As u said the same instructions are not relevant here.

[jywarren]

We actually stripped out a lot of extra content to make the questions form simpler, but help with the centering would be great! I believe it's possible with Bootstrap's col classes: https://getbootstrap.com/docs/3.3/

Thanks!

[ananyaarun]

Cool I'll take a look at it :smiley:
So its better to not add more instructions and try to center the form instead i guess.

[ananyaarun]

@jywarren , @gauravano How does this look ? I centered it and we dont need to add unwanted instructions as u said :)

I also made it a little bigger as there was too much white space otherwise.

[jywarren]

Looks great, can you try it out at narrow screen widths too to be sure it
works on different devices? Thanks!

On Thu, Mar 21, 2019 at 3:46 PM Ananya Arun [e-mail]
wrote:

[image: editor]
https://user-images.githubusercontent.com/32260628/54780541-065eba00-4c40-11e9-9726-3e50814066d4.png

@jywarren https://github.com/jywarren , @gauravano
https://github.com/gauravano How does this look ? I centered it and we
dont need to add unwanted instructions as u said :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5150#issuecomment-475376393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5UwQq3o3umCDClu69STuFBxfPmyks5vY-GMgaJpZM4b5m8v
.

[ananyaarun]

Here is a Gif on narrow screen width.
Does it look fine ?
I'll open a PR if this is ok :)