Plots2: Signing up for a new account when viewing a user's profile page populates the sign up modal with the details of the currently-viewed user

[madeofhuman]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
• [ ] 📝 Update _signupLoginModal.html.erb to clear the form fields when the modal is mounted.

Add modal.find("input[type=text], textarea").val(""); after line 46.

Current Behavior
Clicking the Sign up button on a user's profile page when signed out populates the sign up modal with the details of the user whose profile page you're on.

Expected Behavior
The sign up modal should initialise without any data in it.

• [ ] 💾 Commit your changes
• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

[madeofhuman]

@gauravano, @jywarren, @cesswairimu could you please review this. 😄 Thank you.

[grvsachdeva]

Hey @madeofhuman, it's a privacy issue too :open_mouth: as Email shouldn't be leaked. Let's put this on priority!!!

Also, as it's a FTO, please add code to solve it too. Thanks!

[grvsachdeva]

@kuja24 you want to work in this one?

[kuja24]

Yes I would like to work on it.

[mgroovyank]

@kuja24 Are you doing it?

[kuja24]

yes I'm working on it

[kuja24]

@gauravano @jywarren @cesswairimu
I went through the setup installations instructions in the README file. I have successfully cloned the repository but I'm not able to run the bundle command to set it up locally .Please help solving this error

[kuja24]

I searched on the internet for the error.Do I need to install Ruby first?

[madeofhuman]

@kuja24 run the command ruby -v and tell me what you see

[kuja24]

The term 'ruby' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the
spelling of the name, or if a path was included, verify that the path is correct and try again.
This is what I get

[madeofhuman]

That's okay. It means you do not have ruby installed on your system. Here's how we're going to install it on Windows 10: https://gorails.com/setup/windows/10

[kuja24]

hey @gauravano @jywarren
I'm working on the issue. I will update you about the status tonight.

[kuja24]

I installed windows subsystem for linux . I had added the feature and i am able to see bash in the search option but i'm not able to open it.

@madeofhuman please help

[grvsachdeva]

Ah, I haven't run bash on windows,but may find some help here - https://github.com/publiclab/plots2/issues/3840 also. And, if needed you can ask for cloud9 invite from us. Thanks!

[kuja24]

I have mailed on [email protected] . So could you please send me an invite to work on cloud9.

[shubhank-saxena]

@kuja24 still up for the task? Do let me know if you are facing any difficulties as I have set up the environment and codebase. Will be happy to help!

[shubhank-saxena]

@madeofhuman I would like to claim the problem,as I have completed all of my setup procedures

[grvsachdeva]

@madeofhuman can you confirm the presence of this issue by checking one more time as I checked again and it seems solved?

[jywarren]

Hi, all - actually we found that there was a security issue with these
being published, and we made a lower-level change to prevent the emails
from being displayed. I'm sorry I didn't check in on this PR but we were
eager to complete the fix to avoid peoples' emails being shown on the site,
and I should have reconnected with you immediately once it was published,
but it was late at night.

Given this, I think we are OK now on this issue, and could close it. I'm
sorry about all this! Sometimes we take quick action on something we deem
to be a security/privacy issue and I should have followed up better. Thanks
for all your work and I hope we can get folks plugged into another issue!

On Fri, Mar 22, 2019 at 11:14 AM Gaurav Sachdeva [e-mail]
wrote:

@madeofhuman https://github.com/madeofhuman can you confirm the
presence of this issue by checking one more time as I checked again and it
seems solved?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5065#issuecomment-475659422,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ7gqTPLGiTOJhimg9IGQw4wlmLqFks5vZPMngaJpZM4b0Fh9
.

[grvsachdeva]

Thanks @jywarren for solving this and yes, it's understandable. Thanks all. Closing it now.

[grvsachdeva]

@kuja24 added your name to the list again and will ping you with a new issue soon. Sorry for the inconvenience,

[madeofhuman]

@gauravano I'm sorry for the late response, but yes, it's working. Thanks @jywarren