Plots2: Footer not sticking to the bottom of the screen on pages with little content on large displays

[madeofhuman]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
• [ ] 📝 Update edit thw stylesheets folder to add styles that address this issue. You can check out this article for help.

Current Behavior
Visiting the following pages: _https://publiclab.org/settings_, _https://publiclab.org/subscriptions (when you have little or no subscriptions)_, _https://publiclab.org/subscriptions/digest (when you have little or no subscriptions)_, _https://pubiclab.org/:user/likes (when you have little or no liked content)_ will show a footer that is pushed up and does not stick to the bottom of the page.

The above images are the only pages with little content I could find on production, but note that the behaviour will be replicated on any page with little content, as evidenced by this screenshot of a page on development:

Expected Behavior
The footer should stick to the bottom of the screen, no matter the height of the content.

• [ ] 💾 Commit your changes
• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

[madeofhuman]

@gauravano @cesswairimu @jywarren what do you think of this?

[grvsachdeva]

@fabsar you can work on this one. Thanks!

[sargamm]

thank you! will do that.

[shubhi2000]

@fabsar are you working on this issue?

[sargamm]

Yes, I am working on it.

[shubhi2000]

okay. All the best!

[grvsachdeva]

hey @shubhi2000, if you are looking for first-timer issue, then we can add your name to the - https://github.com/publiclab/plots2/issues/4963 list and can ping you when a new issue is opened?

[shubhi2000]

Yes, I am a first-timer and am looking for an issue. Please add my name to
it. Thanks.

On Sat 16 Mar, 2019 4:58 pm Gaurav Sachdeva, [e-mail]
wrote:

hey @shubhi2000 https://github.com/shubhi2000, if you are looking for
first-timer issue, then we can add your name to the - #4963
https://github.com/publiclab/plots2/issues/4963 list and can ping you
when a new issue is opened?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5059#issuecomment-473522118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AsdXvXwcAKyVJABMSC5291lJztl_8N3Aks5vXNVagaJpZM4bypFz
.

[sargamm]

thank you @shubhi2000 ! All the best to you too!!

[shubhi2000]

In the description of this issue, there is a link to stylesheets folder in the Update section. In that folder, many css files are given. Out of those, the file having footer styling is style.css .

[sargamm]

Oh Okay! Thank you :)

[sargamm]

I am unable to setup the environment for testing the code and the changes I made to it. I followed the instructions given for standard installation. I cannot get through with the 4th step. It says permission denied when I try to run the command gem install bundler. it gives the following error:ERROR: While executing gem ... (Gem::FilePermissionError)
You don't have write permissions for the /usr/local/bin directory.
Please help!

[sargamm]

I have made a pull request. kindly review it @gauravano . Thanks!

[grvsachdeva]

Hey @fabsar, try with sudo?

[sargamm]

Hey! I could run gem install bundler but bundle update isn't working now

[grvsachdeva]

what output you're getting on running bundle update?

[sargamm]

It's working now. Thanks:)

[starcruizer]

hey @gauravano can you please add my name to the - #4963 list and can ping me when a new issue is opened?

[grvsachdeva]

Just added :+1:

[starcruizer]

Thankyou @gauravano

[Linda-Ikechukwu]

Hi, has this issue been resolved, I would love to work on it. I'm an outreachy intern..

[jywarren]

Hi! Would you mind creating an account on PublicLab.org and checking on the
publiclab.org/settings page? Uploading a screenshot to confirm would also
be helpful to verify if it's been fixed! Thank you!

On Thu, Oct 3, 2019 at 6:27 PM Linda Ikechukwu [e-mail]
wrote:

Hi, has this issue been resolved, I would love to work on it. I'm an
outreachy intern..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5059?email_source=notifications&email_token=AAAF6J4NV7XQDCYGDFOFDWLQMZWSDA5CNFSM4G6KSFZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAJY77A#issuecomment-538152956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J2MTRLPXCKPATW2SL3QMZWSDANCNFSM4G6KSFZQ
.

[avats-dev]

@jywarren this is not resolved yet. From what I've seen in above screenshots, previously there was no topics section and hence now it is hard to see this generally but if you zoom out, then it's visible. I'm adding a screenshot here for reference.

Also, @Asu1996 you can work on this one. See above conversation and #5124 for insights. Thanks. :+1:

[Asu1996]

Thank you. @avats-dev I am right on it.

[Asu1996]

I am not getting any text in the footer?
Thank you.

[cesswairimu]

Hi @Asu1996, the contents of the footer are loaded in prod only. You could try adding content on this file to get some content locally https://github.com/publiclab/plots2/blob/main/app/views/layouts/_footer.html.erb. Thanks

[jywarren]

Addressing and closing this in #8537, apologies, folks! Thank you all!!!