Plots2: Bootstrap tooltip data placement parameter is wrong

[ananyaarun]

Description

The comment pop up on hovering over the navbar in the donate page goes out of screen.

Current Behavior

Expected Behavior

The pop up comment stays within the screen.
This can be achieved by changing the placement parameter from 'top' to 'bottom'.

[ananyaarun]

@gauravano , I'd like to fix this issue if approved :)

[gautamig54]

@ananyaarun I am able to solve this issue and have created PR

[ananyaarun]

@gautamig54 Hi, I have solved this issue while creating it itself :) was waiting for @gauravano to approve of the issue to open my PR. Thanks! If this is your first time contributing look for some First timers issue. Claim it, get it assigned and then make your PR. Good luck :+1:

[gautamig54]

@ananyaarun thanks!

[grvsachdeva]

hey @ananyaarun, as tooltips for all the options open at top on wiki so instead of changing the position, do you think we can work to change the width of the tooltip to accommodate the text in minimum lines?

[grvsachdeva]

Also, this bug comes when there is no main image on the wiki so we might want to ignore it. Let's ask @jywarren as they spend many hours on the website.

Thanks!

[ananyaarun]

@gauravano Even i thought this problem goes if a main image is present, but that isnt the case as seen here in the public labs site.

Sure changing the width is indeed a great idea but only the content in the tooltip varies so which would be optimal is a bit of trial and error.

[CleverFool77]

But I guess the screenshot you showed is the one popup which is having maximum content length. Others are usually small :thinking: . So it might not matter if you set the width according to it, I guess. I'm not sure, Its an opinion.

[grvsachdeva]

1. changing width of tooltip
   any other ideas?

[ananyaarun]

@gauravano , i'll give that a try.

[ananyaarun]

@gauravano , changing width would mean we override the default CSS of bootstrap. Is that preferable ? Cuz making the width bigger/different only for 1 tag is not a good solution , also making all of them bigger isnt either as they have different content length. So do u think its better to change the width of all or change only for the one going out of screen or avoid changing and make all the tooltip pop ups open at the bottom ?

[jywarren]

Oh that would be great. You might also make a first-timers-only issue from
it if you're interested! It could be fun to use this to welcome someone
else into the community as well!

On Sun, Mar 10, 2019 at 1:39 PM Ananya Arun [e-mail]
wrote:

I'd like to fix this issue :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4995#issuecomment-471326998,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0NLitBq61tFssA5VFkCLPYcG4-xks5vVUMkgaJpZM4bnZSn
.

[ananyaarun]

@jywarren Sure I'll make this a new FTO issue :)
Also @gauravano just confirming before i open an issue , so the fix for this in the newcomers issue would be to change all tooltips on the page to pop up to the bottom right ? Let me know i'll edit the template if required :)

[ananyaarun]

@jywarren , @gauravano an interesting finding in this regard. The tooltips are actually not designed in a consistent manner right now. Just noticed both on my local installation and public labs page that most actually pop upward while some pop downwards like these on the comments section of Donate page. It is the same comment content that pops up/down on different pages.

I'll open an issue regarding this, we can discuss further there.

[ananyaarun]

Closing this issue as 2 FTO's that fix this have been opened.

[grvsachdeva]

Great!