Plots2: Align download as buttons on smaller screens

Created on 9 Mar 2019  ยท  22Comments  ยท  Source: publiclab/plots2

Created specifically for @karunagoyalk

๐Ÿค” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

๐Ÿ“‹ Step by Step

  • [ ] ๐Ÿ™‹ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] ๐Ÿ“ Update:
    At https://publiclab.org/stats the download as buttons are not well aligned(To see this locally login as admin) are not aligned well on smaller screens.
    download

https://github.com/publiclab/plots2/blob/master/app/views/stats/_range.html.erb#L32-L94

Update

 <div class="row">
 <div class="col-md-4 col-md-offset-2">
</div>
&emsp;
<div class="col-md-3">
 </div>
</div>

After changing the view, also attach the screenshot of updated view in the PR. (You probably have to go on responsive design mode by pressing Ctrl+shift+M)

  • [ ] ๐Ÿ’พ Commit your changes

  • [ ] ๐Ÿ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] ๐Ÿ Done Ask in comments for a review :)

๐Ÿค”โ“ Questions?

Leave a comment below!

assigned first-timers-only

Most helpful comment

@cesswairimu @gauravano thanks! I will work on it

All 22 comments

@karunagoyalk here you go

Hello @cesswairimu has is this issue already claimed?

Hey @GettyOrawo, this issue was created for @karunagoyalk as they were searching for an issue to take on. Are you looking for a FTO?

@cesswairimu @gauravano thanks! I will work on it

Hi I am an Outreachy applicant, could I be assigned to this issue to work on? Or maybe you have another issue you could assign me to start working :) Thanks @gauravano

Hi @karunagoyalk how is this coming along?

@cesswairimu hey! Actually i faced some problem while installing and building the project.But I am trying , i will get back to you in some time with PR

Okay cool. rem to checkout https://github.com/publiclab/plots2/issues/3840 to see if there are any issues you are getting that was solved there or add a comment with your error and we can try and help

Hey! @cesswairimu I have mailed for Free invite for cloud9, But I did not get any response yet!

Hey @karunagoyalk Not sure accepts the access requests for c9 but let me find out. Did you have installations problems? Maybe you can edit it on github and I will help add the screenshot for you?

Hey! @cesswairimu I have done the editing on github! please help me in adding screenshot.

cool, on it

Hey @karunagoyalk could you create a new branch.
go here
Screenshot from 2019-03-17 21-38-51

and type fix-download-buttons when the create blue highlight comes click on it..so we can make a pull request from that branch. Thanks

Hey @cesswairimu I have created the branch,as per you suggested me to do!

Awesome seen it...one last thing I want you to make the pull request. just go here https://github.com/karunagoyalk/plots2/tree/Fix-download-buttons then click the Compare button on the right side. Then just click the create pull request green button then we are set

Hey @cesswairimu what is this?
Screenshot

@cesswairimu Hey! I am new to open source, please help me , what to do here as I have not added any Screenshot
Screenshot from 2019-03-18 20-09-45

I will add it for you just now...awesome creating a pull request :tada:

Hey @karunagoyalk added the screenshot and left a comment. You can edit this by going here https://github.com/publiclab/plots2/pull/5152/files an then hit the edit kaykay
and change line 33 to <div class="col-md-4 col-md-offset-1"> after that just commit then we are ready. Thanks

@cesswairimu Hey! thanks alot for helping me in creating my first PR.I have done the final editing, Can you please have a look,Let me know!

@cesswairimu Hey! Can you assign me some other issue to work on?

Hey @karunagoyalk you can through these issues https://github.com/publiclab/plots2/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22 and see if there is an issue you can work on. Feel free to ping me if you get stuck. Also I would suggest you install the code locally or have it set on C9 for easier testing.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

grvsachdeva picture grvsachdeva  ยท  196Comments

sagarpreet-chadha picture sagarpreet-chadha  ยท  152Comments

grvsachdeva picture grvsachdeva  ยท  183Comments

gautamig54 picture gautamig54  ยท  84Comments

SidharthBansal picture SidharthBansal  ยท  142Comments