Plots2: Refining /stats preset ranges routes

[cesswairimu]

Where to look

https://github.com/publiclab/plots2/blob/master/app/views/stats/index.html.erb#L16-L19
Right now on selecting an option the url is /stats?options= which is defined in this line https://github.com/publiclab/plots2/blob/master/app/controllers/stats_controller.rb#L12

Change to be made

On post the url should be /stats?start=&end=

[thefifthisa]

Hi, I'm new here and would like to work on this!

[cesswairimu]

Hi @thefifthisa, awesome go ahead. Feel free to ask for help here if you are stuck.

[thefifthisa]

Thanks @cesswairimu! To clarify, will I need to create the post method? I only see get here.

[cesswairimu]

@thefifthisa oh yeah I see..I guess it has always been a get. I believe adding a post is not necessary. We want the filter period dropdown to be using the same params as we used in the date selector. That is start and end..

This will mean explicitly setting start and end...end will be Time.now for all the options and start will be Time.now -1.month for month and so on..also another way would be to make the select options urls go for example past week will have the the link /stats?start=<%= Time.now - 1.week %> &end=<%= Time.now %> not sure if making the the options url is possible yet . Hope this helps

[ananyaarun]

@thefifthisa R u still working on this ? Else I'd love to take this up. Thanks :)

[cesswairimu]

This was fix. closing it. Thanks all