Plots2: Inconcistency in the number of comments at research notes

Created on 3 Mar 2019  Â·  9Comments  Â·  Source: publiclab/plots2

image
1comment at the top vs 0 comments at the bottom.

bug

Most helpful comment

oh hmm, do you think it's counting spam comments?

On Sun, Mar 3, 2019 at 2:51 PM Sidharth Bansal notifications@github.com
wrote:

Refer
https://publiclab.org/notes/er_jkshah/02-28-2019/global-warming-and-greenhouse-effect#comments

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4905#issuecomment-469057224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_RXVfdw2FL86H6VXAsJ6TMsQXdyks5vTCeQgaJpZM4bbMiP
.

All 9 comments

oh hmm, do you think it's counting spam comments?

On Sun, Mar 3, 2019 at 2:51 PM Sidharth Bansal notifications@github.com
wrote:

Refer
https://publiclab.org/notes/er_jkshah/02-28-2019/global-warming-and-greenhouse-effect#comments

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4905#issuecomment-469057224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_RXVfdw2FL86H6VXAsJ6TMsQXdyks5vTCeQgaJpZM4bbMiP
.

@SidharthBansal you must close this issue for it has been resolved.

There is some problem with the role. I guess the banned user comments are
also counted. So please change the model code to have role of normal user
only.
Thanks

On Tue, Mar 12, 2019, 1:39 PM Anjali Jain notifications@github.com wrote:

i would like to work on this issue, please help me get started.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4905#issuecomment-471897597,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ5tWzAlhNyiyx1bUeXZ5zOc1Xc4Oks5vV2DWgaJpZM4bbMiP
.

Now it shows 0 comments on the top and bottom both
comments

moderators may have deleted those comments, that's why count looks normal now.
I checked the code and yes, comments other than status = 1 are also counted. Let's use fetch_comments function which gives comments as per user status. I created that some time ago, and it can be used here.

@Anjalizi you want to solve this issue or can I create FTOs from here?

Thanks!

I want to solve this issue.

Great, go ahead!

Hello, is this issue still open? Because I checked, and the number of comments at the top which were inconsistent with that at the bottom have been removed. I'm an Outreachy internship applicant and would like to work on this, but I don't really understand what is expected to be done here

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jywarren picture jywarren  Â·  3Comments

first-timers[bot] picture first-timers[bot]  Â·  3Comments

first-timers[bot] picture first-timers[bot]  Â·  3Comments

keshavsethi picture keshavsethi  Â·  3Comments

grvsachdeva picture grvsachdeva  Â·  3Comments