Plots2: Editor bottom-bar takes up a lot of space on mobile: let's compact it

[jywarren]

I'll upload a screenshot in a moment, but I think we can do a lot to help here!

[jywarren]

There- - uploaded. I think there are a few other things we can do to improve this as well! Maybe, compacting the upload modal, and making sure the tools bar doesn't overlap the modal.

Some of these could be solved in https://github.com/publiclab/PublicLab.Editor/ - and we can move this over there if people prefer.

All this should be doable in CSS, and you can simulate it by going to https://publiclab.org/post and using the Chrome dev console to tweak the CSS styles.

Thanks!

[arungoel123456]

@jywarren allow me to work on this issue

[grvsachdeva]

Hi @arungoel123456, you can surely help. This issue needs to be solved in PublicLab.Editor and you can contact @rexagod for guidance about the editor. Thanks!

[arungoel123456]

Can u please tell what is Editor

[grvsachdeva]

We use Publiclab.Editor - https://github.com/publiclab/PublicLab.Editor/ as
integration in plots2 for the work, so if this issue is in that repo, we
can solve it there and make a update here.

On Tue 12 Feb, 2019, 11:36 AM Arun Goel <[email protected] wrote:

Can u please tell what is Editor

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4776#issuecomment-462628800,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT6S9tn1BAmEBX67wMEWAW2AbHzSJA2Qks5vMlnwgaJpZM4arCoM
.

[arungoel123456]

Sorry @gauravano . For this issue , I need to install node . And I don't have interest in node . So I request u to give this issue to someone else

[grvsachdeva]

No issue @arungoel123456! There are plenty of other issues open, you can help us with them. Thanks!

[sresthas]

Hey, I am an Outreachy applicant, can I take this up?

[jywarren]

Yes please, that'd be great!

On Wed, Mar 6, 2019, 1:49 PM Srestha Srivastava [e-mail]
wrote:

Hey, I am an Outreachy applicant, can I take this up?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4776#issuecomment-470228214,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_9MQBQziL5kWut4xQ1kc2iSa9giks5vUA2qgaJpZM4arCoM
.

[divyabaid16]

Hey!!
Can I work on this?

[rexagod]

Sure @divyabaid16, go ahead!

[divyabaid16]

I had the reverse case. i.e the modal was overlapping the toolbar.
GIF

Here (I guess) modal should be invisible in rest of the part except the text area.

I could find many more issues here, some of them were not reported earlier. I tried to open up the issue but it was getting very long.

What if we migrate the text editor in React?
It is component based so it would be easirer to write and debugg. Also, the Virtual DOM allows the UI to be efficient.

@jywarren @gauravano @rexagod what are your views in this?

[jywarren]

I think we are not quite ready to migrate the editor to React, and even if
we did, we would still want to solve the HTML/CSS design issues here, no? I
like the idea in the longer term, though!!!

Regarding the issues you've found, we would LOVE to see them written out.
You don't have to write them all out, but just getting an issue started
would be so helpful!!

Thanks!

On Wed, Mar 27, 2019 at 11:52 PM Divya Baid [e-mail]
wrote:

I had the reverse case. i.e the modal was overlapping the toolbar.
GIF
[image: Peek 2019-03-28 09-00]
https://user-images.githubusercontent.com/32747809/55128081-4f2edb00-5138-11e9-996a-edfaf6a13dba.gif

Here (I guess) modal should be invisible in rest of the part except the
text area.

I could find many more issues here, some of them were not reported
earlier. I tried to open up the issue but it was getting very long.

What if we migrate the text editor in React?
It is component based so it would be easirer to write and debugg. Also,
the Virtual DOM allows the UI to be efficient.

@jywarren https://github.com/jywarren @gauravano
https://github.com/gauravano @rexagod https://github.com/rexagod what
are your views in this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4776#issuecomment-477437283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxYxZxBpJlpnBG0arhRyfO7-56w1ks5vbDxngaJpZM4arCoM
.

[jywarren]

Hi @CleverFool77 @gautamig54 would this be an issue you might be able to add to your summer project plan? Thank you!

[jywarren]

@keshav234156 thank you for your interest!

@jywarren .would like to work on this issue. i think the problem of appearring toolbar infront of prompt has already been fixed in PublicLab.Editor/pull/248.Is it what is expected behaviour(that already present as of now) or anything other than this is expected behavior?

I am thinking that we should try to make this whole section much more compact:

Maybe it could be something like:

(for the bottom bar, at least?) And, using https://getbootstrap.com/docs/4.3/components/ as much as possible!

Does that sound interesting?