Plots2: header wrapping issues at some window sizes (recurring issue)

[jywarren]

We keep seeing issues with the header wrapping to 2 lines as items are added or removed from the header, and I'd like to think about how to address this - both the current issue and how to prevent this in the future.

Right now I believe the new icons added have increased the width beyond the breakpoints in CSS. Read more about the issue here:

https://github.com/publiclab/plots2/issues/4502

One open PR is being blocked by this issue as well.

https://github.com/publiclab/plots2/pull/4461

Which is discouraging for the author, I'm sure!

Let's solve the immediate issue by removing the icons until we can fix the wrapping, and let's brainstorm a plan to either block edits to this code or to have a more flexible layout which can survive some changes without breaking.

Thanks everyone for your patience, this is a delicate section of code and we appreciate your help!!

[IshaGupta18]

Yes, removing the icons is solving this issue momentarily, we can brainstorm to make this code more flexible. But for now, do you want to remove the icons, I could make a PR for it @jywarren ?

[jywarren]

That'd be great, thank you!

On Sun, Jan 27, 2019, 12:15 PM Isha Gupta <[email protected] wrote:

Yes, removing the icons is solving this issue momentarily, we can
brainstorm to make this code more flexible. But for now, do you want to
remove the icons, I could make a PR for it?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4690#issuecomment-457926187,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ1lFvFgCAzpX-sXAd_3op_tmhe_8ks5vHcKFgaJpZM4aMlLP
.

[grvsachdeva]

Hi @jywarren, the menu work is in progress at https://github.com/publiclab/plots2/pull/4517 , so you can add your comments there to help @Chrisyee22.

@IshaGupta18 you can collaborate with @Chrisyee at #4517 so that issue can be resolved as soon as possible. Thanks!

[IshaGupta18]

Yes absolutely @gauravano ! @jywarren #4713 is my PR for the temporary fix. Thanks a lot!

[siddhishree]

@IshaGupta18 Can I work on this Issue with you?

[IshaGupta18]

I am so sorry I missed your comment @siddhishree . Please feel free to work on this issue. We would love your help here!

[jywarren]

I think we are OK on this, can someone try resizing the header to very small sizes and check that it doesn't fold to 2 lines when we do it? If we're OK, then we can close this for now!

[IshaGupta18]

Checked! Works fine!

On Mon, Mar 25, 2019, 8:23 PM Jeffrey Warren [e-mail]
wrote:

I think we are OK on this, can someone try resizing the header to very
small sizes and check that it doesn't fold to 2 lines when we do it? If
we're OK, then we can close this for now!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4690#issuecomment-476232270,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Am54Z5gyaJc21p8TOlQ0BO4ZTY84wHmHks5vaOMAgaJpZM4aMlLP
.

[jywarren]

Thanks IshaGupta!

[grvsachdeva]

Great!

On Mon, Mar 25, 2019 at 8:53 PM Jeffrey Warren [e-mail]
wrote:

Thanks IshaGupta!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4690#issuecomment-476246046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT6S9hZNLJsqt1qnm3eCm5g3NRNSqMQWks5vaOn0gaJpZM4aMlLP
.