Plots2: Route Error in logging in from wiki/events

[IshaGupta18]

When on page /wiki/events and trying to log in from there, this error has been caught.

Kindly have a look at it. Your help is truly appreciated.

[SidharthBansal]

Thanks Isha for reporting the issue.
Nice catch

[IshaGupta18]

No problem!

[grvsachdeva]

Hi @IshaGupta18 could you point using which button or link you tried logging in? Also, if you want to solve it yourself, please go ahead. Thanks!

[IshaGupta18]

The login button in nav bar. I even tried linking a button to login modal and logging in through that from the same oage (wiki/events) but it still didn't work, because both would mean the same altogether. I am so sorry but currently I am working on #4344 . In case it's done in time, I'll try to do this as well. If anyone wants to start working on this one, they are most welcome to.

[grvsachdeva]

Okay, I reproduced the error and the issue persists on every page except root url . It's introduced in #4334. Solving now!

Thanks @IshaGupta18 for reporting!

[IshaGupta18]

No problem! Thanks a lot!

[oorjitchowdhary]

@sidharthbansal this is the same error I was getting at #4254
Glad @ishagupta18 had reported this earlier

[IshaGupta18]

Hey I locally tried @gauravano fix for this and it works really well, however, whenever I login (and probably wherever I login from) , I am redirected to root with this message, was this message intended to be there? (PS: I am sure it had nothing to do with @gauravano 's fix, if this message is an error)

[grvsachdeva]

Hey @IshaGupta18 @oorjitchowdhary I have resolved the login issue. @oorjitchowdhary please update your PR.

@IshaGupta18 yes, that error is not related to my fix. That error or say message is coming when you are on /login and try to login using modal?

[IshaGupta18]

Both I believe. So this is an error, right?

[grvsachdeva]

Whenever at time of login return to would be carrying ''/login" then this message would come, as login page can only be shown to logged out user. I don't think it should come at every page. This can be handled by removing the return_to if it contains "/login" . If you can specify, particular page or button at which this message is coming, then it would be of help. Thanks!

[IshaGupta18]

By every page I meant on logging in from any page you are on right now.

[grvsachdeva]

Could you please paste the logs or GIF as I am unable to reproduce the error. I am trying on stable.publiclab.org as it is updated with master branch. Thanks!

[IshaGupta18]

Hey would this do? I just wanted to let you know about this flash message. I am sorry if I am wrong.

[SidharthBansal]

I have opened this issue as both of you are working on it. Once the issue which you both collaboratively are trying to solve is resolved, please feel free to close this issue.

[grvsachdeva]

Tried on stable.publiclab.org

Will check on localhost soon..

[SidharthBansal]

What's the status?

[grvsachdeva]

I have tried localhost too, but can't reproduce the error faced by @IshaGupta18. @SidharthBansal could you try this and let us know if you get same error anwhere?

[IshaGupta18]

I think it is fixed now @gauravano

[IshaGupta18]

It was probably my fault. I am terribly sorry.

[grvsachdeva]

You don't need to be sorry if you observed error and we can't find it now or even if that error was due to outdated branch.

It's good if it's fixed but if you see it again then don't feel shy to open a new issue.

Thanks @IshaGupta18 :)

[IshaGupta18]

Okay Thanks a lot! I am glad the main issue here is resolved!