Plots2: Login modal shows up abruptly

[oorjitchowdhary]

Please describe the problem (or idea)

When clicked link a location button on a particular page, the map shows up the the usual way but the login modal is displayed behind it.
This is happening when the user is logged in.

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

The login modal shouldn't have appeared.

Please show us where to look

https://publiclab.org/notes/bryanchua/12-18-2018/hydro-powered-diy-ftir-spectrometer

What's your PublicLab.org username?

oorjit_chowdhary

Browser, version, and operating system

Chrome, Windows 10

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[oorjitchowdhary]

@publiclab/mentors This should be looked into quickly as we have released it on PL...

[SidharthBansal]

Thanks for a great catch.

[jywarren]

Yes, thanks!!! It'll be related to the z-index css value!

On Fri, Dec 21, 2018, 8:27 AM Sidharth Bansal <[email protected]
wrote:

Thanks for a great catch.

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4348#issuecomment-449388194,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0lOcQide05To9FRg4iWw95Ek-Wnks5u7OG2gaJpZM4Zdt2v
.

[grvsachdeva]

Hi @oorjitchowdhary would you be interested in solving this one?

[oorjitchowdhary]

@gauravano I'm not sure how can I solve this one.. I'm unable to find the fix

[oorjitchowdhary]

A little bit of help and I think I may be able to pull it off

[kevinzluo]

The issue is with https://github.com/publiclab/plots2/blob/fefa4aa7ed91776a7b1b25902e804089de2f9d89/app/views/tag/_location.html.erb#L14-L15

The selector targets both the blurred location modal and the new login modal. We need to make it select only the blurred input modal. @oorjitchowdhary would you like to fix this? I think adding a unique id to the location modal and then changing the selector will fix this.

[SidharthBansal]

I have assigned this issue to Oorjit. Kevin is helping him and this is great appreciated.
Thanks

[oorjitchowdhary]

Hi, @SidharthBansal .. I'm really sorry I won't be able to complete this one. I'm gonna be off laptop for a while as I'm on a vacation.

[kevinzluo]

No worries @oorjitchowdhary . I will try to submit a fix then.

[oorjitchowdhary]

Thanks a lot Kevin.
Sorry for the trouble.