Plots2: Link Login modal to blog tag page

[SidharthBansal]

We have a button to follow and unfollow on the tag/blog. We need to link it to the login modal if the person is not logged in.

[SidharthBansal]

This is the Login button which @dinaelhanan you have fixed in your pr.

[SidharthBansal]

Thanks

[SidharthBansal]

I think it is not working.
Let us check it. @dinaelhanan

[digitaldina]

@SidharthBansal I don't think my PR fixed the blog one, I think it only fixes following tags. Also that writing on the blog is not a link. Should I make it a link and link the login modal?

[SidharthBansal]

I am trying to explain you that you did PR for this issue instead of the tag one. You have changed the wrong files. I merged it because we also need this blog change. Still the tag issue is not solved.
You targetted wrong file in the PR.

[digitaldina]

@SidharthBansal ok so if I understand correctly, the tag still doesn't have link to login modal. I understand that. I'm just wondering if the blog one that I accidently worked on is fixed? Because you re-opened this issue?

[SidharthBansal]

Neither of the two issues are fixed.

On Sun, Dec 23, 2018, 8:43 PM d1g1t4ld1n4 <[email protected] wrote:

@SidharthBansal https://github.com/SidharthBansal ok so if I understand
correctly, the tag still doesn't have link to login modal. I understand
that. I'm just wondering if the blog one that I accidently worked on is
fixed? Because you re-opened this issue?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4335#issuecomment-449642875,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQxLoPEe5USj4srSOFw3IqHVbnqGDks5u752QgaJpZM4Zaabo
.

[digitaldina]

@SidharthBansal :/ ok I'll check it out :+1: