Plots2: 'Link social media' button doesn't work

[oorjitchowdhary]

Please describe the problem (or idea)

The link social media button doesn't work.
It displays a dimmed screen. I'm guessing that's for a modal to appear but nothing happens.

https://github.com/publiclab/plots2/blob/bb48d317502e73f6e236c7870e74da174e021050/app/views/users/profile.html.erb#L216-L235

There seems to be a modal, which isn't appearing for me.

Please show us where to look

https://publiclab.org/profile/oorjit_chowdhary

What's your PublicLab.org username?

oorjit_chowdhary

Browser, version, and operating system

Chrome, Windows 10

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[oorjitchowdhary]

@publiclab/reviewers What could be done here

[SidharthBansal]

We can try to fix it. Current fix is display of the modal. I know the further steps, but let's fix the frontend first.
Please check this out at publiclab.org and unstable and tell me the behaviour.

[SidharthBansal]

@jywarren I know that we should integrate OAuth providers here. But for that I need to integrate Instagram into PL. And I guess my existing project will not give me a second to think about it at the present moment. So, we will be doing this once my Subscription project gets completed and the modal issues too. What do you say @jywarren ?

[oorjitchowdhary]

The gif depicts the behaviour at publiclab.org .. I'm unable to access unstable at the moment.. It says the build failed

[grvsachdeva]

I think there is a bug in action. Looks screen color fades but modal content was unable to show. @oorjitchowdhary would you like to open FTO from this issue. Thanks!

As Oauth would take time, quick fix would be to fix the existing. @SidharthBansal thoughts?

[SidharthBansal]

Quick fix is fixing the modal

On Thu, Dec 13, 2018, 2:21 AM Gaurav Sachdeva <[email protected]
wrote:

I think there is a bug in action. Looks screen color fades but modal
content was unable to show. @oorjitchowdhary
https://github.com/oorjitchowdhary would you like to open FTO from this
issue. Thanks!

As Oauth would take time, quick fix would be to fix the existing.
@SidharthBansal https://github.com/SidharthBansal thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4281#issuecomment-446739118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ388TerlQtbcHFEhVdPJs-KxLVylks5u4WxNgaJpZM4ZPEKp
.

[SidharthBansal]

We should aim at quick fix here first

On Thu, Dec 13, 2018, 2:24 AM Sidharth Bansal [email protected]
wrote:

Quick fix is fixing the modal

On Thu, Dec 13, 2018, 2:21 AM Gaurav Sachdeva <[email protected]
wrote:

I think there is a bug in action. Looks screen color fades but modal
content was unable to show. @oorjitchowdhary
https://github.com/oorjitchowdhary would you like to open FTO from
this issue. Thanks!

As Oauth would take time, quick fix would be to fix the existing.
@SidharthBansal https://github.com/SidharthBansal thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4281#issuecomment-446739118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ388TerlQtbcHFEhVdPJs-KxLVylks5u4WxNgaJpZM4ZPEKp
.

[IshaGupta18]

On inspecting the page, I noticed that all the components of the modal are there, the cursor even changes to text input cursor on hovering over the input field, but for some reason, it is not visible, even though everything is present there.

I don't know how helpful this observation is, but here it is for your reference anyways. Thank you all.

[oorjitchowdhary]

We can try to fix it. Current fix is display of the modal. I know the further steps, but let's fix the frontend first.
Please check this out at publiclab.org and unstable and tell me the behaviour.

The same behaviour is there with unstable

[tsparksh]

I changed 834 (at rendered view) and it works!
What is this code for? When I was working on this popup, this code did not exist.
.modal-content{ opacity: 0; }

[sagarpreet-chadha]

Hi...this is great !

I think you can open a PR for this .
Before opening the PR can you test if this works fine in different window size ?
Also can you check whether this code was changed recently because it used to work fine before .

Thank you :)

[grvsachdeva]

Hi @thesparks are you currently working on this one? Thanks!

[tsparksh]

@gauravano Hi. I am busy studying now, I need a lot of things to pass. Maybe someone else wants to work on this?

[IshaGupta18]

@gauravano can I create a PR for this then? Would it be okay?

[grvsachdeva]

No issue @thesparks and all the best! Yes @IshaGupta18 please go ahead. Thanks both of you :smiley: !

[IshaGupta18]

4425 is the link to my PR for this issue. I am waiting for approval @gauravano and hope everything works out! Thanks a lot. A special thanks to @thesparks for helping out on this issue!