Plots2: RSS feed page is broken

[oorjitchowdhary]

Please describe the problem (or idea)

I am not so familiar with RSS but I still clicked the button and went to that site.
It comes up with an error at top and then shows up the document tree.

Please show us where to look

https://publiclab.org/feed/oorjit_chowdhary.rss

What's your PublicLab.org username?

oorjit_chowdhary

Browser, version, and operating system

Chrome, Windows 10

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

Problem

[oorjitchowdhary]

@publiclab/reviewers What could be done here?

[grvsachdeva]

Hi @oorjitchowdhary are you talking about this message -

If yes, then that's fine. Google Chrome doesn't support RSS, so if you view the same link in Firefox, you'll observe the change. Let me know if I am wrong.

Thanks!

[jywarren]

Perhaps we should check to be sure this action is tested in our functional
tests, to give us more confidence? It may already be, potentially. Good to
look!

On Sat, Dec 15, 2018, 2:30 PM Gaurav Sachdeva <[email protected]
wrote:

Hi @oorjitchowdhary https://github.com/oorjitchowdhary are you talking
about this message -

[image: error_rss]
https://user-images.githubusercontent.com/20878070/50046711-bbc42380-00cd-11e9-8b6d-c939be838990.png

If yes, then that's fine. Google Chrome doesn't support RSS, so if you
view the same link in Firefox, you'll observe the change. Let me know if I
am wrong.

Thanks!

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4279#issuecomment-447592283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJyjzNnTv46LGuFAVJFjBRtoMWD07ks5u5U3BgaJpZM4ZPBil
.

[digitaldina]

@jywarren is this it? https://github.com/publiclab/plots2/blob/a2c1723bcdeab32757a4e384c76ae4581845f630/test/functional/notes_controller_test.rb#L713-L715

[sagarpreet-chadha]

Hi 😄 !

The above is the test for notes_controller : https://github.com/publiclab/plots2/blob/a2c1723bcdeab32757a4e384c76ae4581845f630/app/controllers/notes_controller.rb#L347

I guess you are looking for users feed (https://publiclab.org/feed/oorjit_chowdhary.rss) , which is tested here :

https://github.com/publiclab/plots2/blob/a2c1723bcdeab32757a4e384c76ae4581845f630/test/functional/users_controller_test.rb#L242

Hope it helps ! Thanks !

[sagarpreet-chadha]

Also i see our feed is not valid . We have to do minor changes .
We can see the changes we have to do using this validator : https://validator.w3.org/feed/check.cgi

If you paste the feed URL which is (https://publiclab.org/feed/oorjit_chowdhary.rss) , you will see 2 minor changes that we have to do while generating RSS feed .

The code that generates the RSS is here : https://github.com/publiclab/plots2/blob/master/app/views/tag/rss.rss.builder

If anyone wants to solve this , i would be happy to help . Thank you 😄 !

[digitaldina]

I'd be glad to take this on! @sagarpreet-chadha thanks for the great help!
I see that this would help solve thhis:
https://validator.w3.org/feed/docs/warning/MissingAtomSelfLink.html
But where would I add this in the file you have linked? Would I do something like below but outside of the if else statements?
https://github.com/dinaelhanan/plots2/blob/2be0ef562f89582577080e4a4111ca9fcec56453/app/views/tag/rss.rss.builder#L29

[grvsachdeva]

Great!

Gaurav Sachdeva

On Tue 18 Dec, 2018, 8:01 PM d1g1t4ld1n4 <[email protected] wrote:

I'd be glad to take this on!

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4279#issuecomment-448239669,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT6S9jRmhOw9tluhYzajh7_LnqKCoTmjks5u6Pw1gaJpZM4ZPBil
.

[digitaldina]

@gauravano @sagarpreet-chadha hey! I'm still looking to solve this, but I was hoping for some direction. Please see my above message. Thanks!

[sagarpreet-chadha]

Hi @dinaelhanan !

The 2 recommendations are these :

First one says that we have to convert this field to following form/syntax :

[email protected] (Joe Smith)

The second recommedation i belief is saying that we have to add this tag :

<atom:link href="https://publiclab.org/feed/oorjit_chowdhary.rss" rel="self" type="application/rss+xml" />

within the <channel> tag , which we already have . See this line :
https://github.com/publiclab/plots2/blob/7d8249ca65885adbf75184701a420785c63661a9/app/views/tag/rss.rss.builder#L5

I think it is saying to add rel="self" attribute to the above link tag . What do you think ?

[digitaldina]

@sagarpreet-chadha thanks for that! I noticed that the first recommendation was fixed and it just has one recommendation:

I have tried to solve this issue in #4354. Thanks for your help!

[sagarpreet-chadha]

Awesome 😄 !