Plots2: 'Follow' icon is the same as 'number of views' icon

Created on 12 Dec 2018 · 17Comments · Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update the files in the plots2 repository (press the little pen Icon) and edit the line as shown below.
https://github.com/publiclab/plots2/blob/eeed6645474a356cdd62fdd9e7c8467935faef1f/app/views/like/_like.html.erb#L14
https://github.com/publiclab/plots2/blob/e6fbd99aa47083be93fd1fa10236f743e5bc4900/app/views/tag/blog.html.erb#L18
https://github.com/publiclab/plots2/blob/6f353b2937af8b523708a9991813bbdbac21987d/app/views/home/subscriptions.html.erb#L9
https://github.com/publiclab/plots2/blob/cfb8b01acce023c19f5476e8b9f6743cb098e7a8/app/views/tag/index.html.erb#L44-L48
https://github.com/publiclab/plots2/blob/5c0d96274bd0be15feba69d8f30093082402ace5/app/views/tag/_contributors.html.erb#L25-L29
https://github.com/publiclab/plots2/blob/3f76b90c3273292e9ab2f96654b9790d265afd99/app/views/tag/contributors-index.html.erb#L47-L51
https://github.com/publiclab/plots2/blob/d5aa3de4459da087aa4d7dca06b515fa39910c53/app/views/tag/show/_user_controls.html.erb#L6-L10

- <i class="fa fa-eye"></i>
+ <i class="fa fa-user-plus" aria-hidden="true"></i>

Problem

While browsing through the PL site, I got confused with this.
The follow icon is the same as the number of views icon. We should change one icon in order to avoid any confusion.

Follow icon
screenshot 110

Views icon
screenshot 111

Solution

I think we can change one logo.
I've a suggestion for changing the follow icon.
I think we can use this icon for the follow buttons on the site.

screenshot 112
https://fontawesome.com/v4.7.0/icon/user-plus

See this page for some help in taking your first steps!

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

first-timers-only

Source

oorjitchowdhary

All 17 comments

@publiclab/reviewers I created this as a fto issue but I have realized this will require changes at multiple locations, should it still be a fto issue?

oorjitchowdhary on 12 Dec 2018

@SidharthBansal What say?

oorjitchowdhary on 12 Dec 2018

It will be better to close this issue and create a single issue where you
can list all the places where we need to change the icons. Right now we are
having 500+ issues so we are looking forward to solving them first. If you
will create issue for each then it will create issue tracker to be
overwhelmed for the mentors. Let's teamwork to resolve the existing issues
first. What do you think?
I really appreciate your hardwork. Thanks for the catch.

On Wed, Dec 12, 2018 at 3:41 PM Oorjit Chowdhary notifications@github.com
wrote:

@SidharthBansal https://github.com/SidharthBansal What say?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4278#issuecomment-446533340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ6meUwFony3VuY0aM4z3P3gmyD-Bks5u4NYygaJpZM4ZPAb-
.

SidharthBansal on 12 Dec 2018

👍1

It will be better to close this issue and create a single issue where you can list all the places where we need to change the icons.

That's a great idea.

Right now we are having 500+ issues so we are looking forward to solving them first. If you will create issue for each then it will create issue tracker to be overwhelmed for the mentors. Let's teamwork to resolve the existing issues first. What do you think? I really appreciate your hardwork. Thanks for the catch.

Okay, sounds good. Let's do this!

oorjitchowdhary on 12 Dec 2018

Oorjit we have :+1: symbols at each comment. If you agree upon the
statement then you can use them instead of commenting. This enables the
conversation to be precise and accurate.

On Wed, Dec 12, 2018 at 4:30 PM Oorjit Chowdhary notifications@github.com
wrote:

Closed #4278 https://github.com/publiclab/plots2/issues/4278.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4278#event-2021171409, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUACQ4vPCd76rdXwfw0ysyfh48ci4VcKks5u4OG5gaJpZM4ZPAb-
.

SidharthBansal on 12 Dec 2018

👍1

Please link it to the new issue which I suggested you to create.

SidharthBansal on 12 Dec 2018

I browsed through the website.. I don't think we require any other changes from the icons perspective...
I think this is the only one... So should I reopen this and all the code links??

oorjitchowdhary on 12 Dec 2018

Yeah please do so.

SidharthBansal on 12 Dec 2018

Done!

oorjitchowdhary on 12 Dec 2018

Can I claim this issue?