Plots2: Issues with Input Fields in Login Modal

[kevinzluo]

Currently at a specific width, the Login Modal errors and the input fields stick out of the body.

I believe this is a CSS issue but I am not too familiar with it.
Perhaps looking into the code here (plots2/app/views/user_sessions/_new.html.erb) will give some answers.

Chrome Ubuntu

[kevinzluo]

Issue also occurs using cloud9 on windows chrome.

[SidharthBansal]

@kevinzluo I guess I have rewarded you for this.

[IshaGupta18]

Hey @kevinzluo @SidharthBansal can anyone tell me where is the css file for making it responsive? I think I have some idea on how to fix this, but I would be needing the css file for that. Thanks a lot.

[SidharthBansal]

Hi I think @kevinzluo has fixed the issue.
Let's ask him first. If the issue is solved then we can close this issue.
Thanks all

[IshaGupta18]

Oh okay, no problem!

[kevinzluo]

Actually I haven't tried solving this issue yet. @IshaGupta18 please go ahead 😄 . I don't really know where the CSS for the modal is contained.

[SidharthBansal]

@IshaGupta18 how is it going?

[IshaGupta18]

I actually fixed this issue by inspecting the site in developer's console. I tried a lot to find the css file where the code for making this responsive is written, but couldn't do so. I think I'll have to think of a different solution, but I can't be sure of finding it, because I tried a lot to resolve this issue before, but couldn't. I am terribly sorry if I caused any delay or trouble in this.

[IshaGupta18]

Will it be okay if I take a little more time in attempting to fix it?

[jywarren]

If you look at the site in the dev console in development mode you should
be able to see the separate css files, but on production they've been
compiled into one giant file so it's harder to track. Good luck! We can
help more if you get stuck!

On Sun, Dec 23, 2018, 8:05 AM Isha Gupta <[email protected] wrote:

Will it be okay if I take a little more time in attempting to fix it?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4244#issuecomment-449635146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxOu_ASzObB-VBYqlwJVNvPtWdkqks5u739ggaJpZM4ZK2QR
.

[IshaGupta18]

Alright, thank you for the tips! I will get back to you in case I get stuck!

[IshaGupta18]

I think this looks a bit better. What do you think @SidharthBansal @jywarren ? Ps: I am really sorry for the poor quality gif.

[IshaGupta18]

@SidharthBansal let me know if it looks good to you.

[SidharthBansal]

Awesome!!!

[IshaGupta18]

Should I create a PR for this then?

[SidharthBansal]

Yeah sure!!!

On Mon, Dec 24, 2018 at 6:12 PM Isha Gupta [e-mail] wrote:

Should I create a PR for this then?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4244#issuecomment-449729688,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQxA4WEnq17EwO-cYWWtXN-7-_h6qks5u8MufgaJpZM4ZK2QR
.

[IshaGupta18]

I am sorry I wasn't able to make a PR for this issue. I am facing some difficulty with git in doing so, I'll make a PR as soon as it is resolved.

[SidharthBansal]

Take your time. No hurry.

On Mon, Dec 24, 2018, 8:29 PM Isha Gupta <[email protected] wrote:

I am sorry I wasn't able to make a PR for this issue. I am facing some
difficulty with git in doing so, I'll make a PR as soon as it is resolved.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4244#issuecomment-449743549,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQyUWHcEqv0zkhHDT0o2uCSoU82Xdks5u8OvsgaJpZM4ZK2QR
.