Plots2: Link login modal to edit wiki button

[JonathanXu1]

Problem

On wiki posts such as this https://publiclab.org/wiki/environmental-estrogen-testing there is an option to edit the page:

📋Solution

Currently when clicked, the user is directed to a login page. We want the button to open a login modal if the user is not logged in.
/app/views/wiki/_header.html.erb

[okonek]

@SidharthBansal Claimed and resolved in here: https://github.com/publiclab/plots2/pull/4258

[JonathanXu1]

@okonek does it open the edit prompt once the user is logged in?

[okonek]

No, it doesn't, but I couldn't find a way that I could without editing the controller's code.

[JonathanXu1]

Check #4239, I'm trying to do something similar too

[okonek]

Ok, I'll check it out in a minute.

[okonek]

Well, after looking at the @kevinzluo code in this PR, I still have no idea how he managed to do that. Maybe he could help us himself?

[kevinzluo]

Hi @okonek . Please take a look at my comment here:https://github.com/publiclab/plots2/pull/4228#issuecomment-446430051

[oorjitchowdhary]

Hi @SidharthBansal, is this issue solved?

[SidharthBansal]

All the issues which are open of OAuth milestone are not solved that is why they are open. I am core mentor for OAuth milestone. So, I will be closing all the issues whenever they will be needed.
Thanks.

[oorjitchowdhary]

I think for this issue's PR #4258 .. we just need the requireLogin class I think

[SidharthBansal]

Yeah, @okonek is working on it.
Please read the conversation fully to avoid confusions.

[oorjitchowdhary]

Yes, I understand. Thank you for the guidance and sorry for the haste approach

[SidharthBansal]

No problem, mentors are there to help you.

[SidharthBansal]

@Dsxv you can do this too if you want. You were having trouble in finding issues so just telling you some issues.

[Dsxv]

@SidharthBansal Thankyou So much for help ! But isn't @okonek working on it?

[SidharthBansal]

He is not online since many days so you can work on it.

On Thu, Jan 10, 2019, 11:07 PM Pawan Shukla <[email protected] wrote:

@SidharthBansal https://github.com/SidharthBansal Thankyou So much for
help ! But isn't @okonek https://github.com/okonek working on it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4242#issuecomment-453185489,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ_OHFEZvG_Ezl-XZ33eytasVjnvJks5vB3pHgaJpZM4ZK0Wg
.

[SidharthBansal]

@Dsxv how is it going here?