Plots2: Link Login Modal to Help Answer future questions

[kevinzluo]

We are creating a login/signup modal, next step is to link to various pages. In this issue we will be linking it to request an activity (The subscription link here). For modularity, this is separate from linking the button.

[oorjitchowdhary]

@kevinzluo Are you working on this one?

[SidharthBansal]

May be yes!
You can work on the existing issues.
Please complete those which you have claimed by the time I reach to review your queries

[SidharthBansal]

@kevinzluo when you submit the patch for this please claim https://codein.withgoogle.com/dashboard/tasks/6357205830860800/

[kevinzluo]

@oorjitchowdhary please go ahead if you wish to work on this one. I am at school and can only access the internet with my phone, so I cannot even code :disappointed: .

[SidharthBansal]

@oorjitchowdhary are you going to create a PR for this? I think this is one of the many issues claimed by you.
Thanks.

[oorjitchowdhary]

https://github.com/publiclab/plots2/blob/70fdeb1a5fb43d33aea71868d6d346c39959ad0b/app/views/grids/_notes.html.erb#L66-L73

The requireLogin class is already implemented here by @kevinzluo ... I think this might have also solved this issue.. But we may need to try it out on localhost.

[oorjitchowdhary]

@SidharthBansal How can I add the grid in the wiki page.. I'm not able to do it.
was it something like [grid:test}?

[SidharthBansal]

I also think that this has solved this issue.
Can you please try out if issue is still present? In case it is not present then please close the issue.
Thanks Oorjit.

[oorjitchowdhary]

I'm trying it out but I'm unable to add the grid to on localhost.. I'm not able to remember the command. How do i add the grid

[SidharthBansal]

I will suggest you to read following first then do other things.
https://publiclab.org/wiki/power-tags this will help you understanding one
of the extra ordinary feature built by @jywarren. Then please continue with
the work. I believe your doubt will be solved after reading it up.

On Thu, Dec 27, 2018, 1:21 AM Oorjit Chowdhary <[email protected]
wrote:

I'm trying it out but I'm unable to add the grid to on localhost.. I'm not
able to remember the command. How do i add the grid

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4231#issuecomment-450016308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ1W-MYSit8dRY2iqHWIkhSczybRRks5u89NCgaJpZM4ZKsS0
.

[oorjitchowdhary]

Hi, @SidharthBansal .. This is not yet solved. I tried it. I was able to link the modal here but the current flow is:

1. User clicks on help answer future questions
2. Login modal shows up
3. A successful sign in redirects to the same page
   Is this flow okay?

I had reported a similar issue #4218 which I'm currently trying to complete.
I have the same error there.
Through, the class='requireLogin', I'm able to display the login modal but it doesn't redirect to the button's command in both the issues #4218 and #4231

[kevinzluo]

Yes @oorjitchowdhary , I also saw that the require login class doesn't work for these types. I think it is because when the user is not logged in the links redirect to a different page. I'm not too sure how to fix this.