Plots2: Inconsistencies for the login modal

[SidharthBansal]

As a collaborative effort of @SidharthBansal @oorjitchowdhary @JonathanXu1 we came to set up the modal on the master branch for the login sequence.
Current Progress.

Localhost

• [x] WORKING Login form validations are working fine for incorrect input fields(testing)

• [x] WORKING Login modal validations are working fine for incorrect input fields(testing)

• [x] WORKING Login form signs a user in successfully(testing)

• [x] WORKING Login modal signs in a user successfully(testing)

• [x] WORKING Login works well on all the webpages(testing)

• [x] WORKING Login is redirected to the same page after user signs up(return_to)(testing)

Unstable

• [ ] Login form validations are working fine for incorrect input fields(testing)
  Unable to test, redirected to PL stable

• [ ] Login modal validations are working fine for incorrect input fields(testing)
  Unable to test, redirected to PL stable

• [x] WORKING Login form signs a user in successfully(testing)

• [x] WORKING Login modal signs in a user successfully(testing)

• [x] Login works well on all the webpages(testing)

• [x] Login is redirected to the same page after user signs up(return_to)(testing)

Refer #4203 for this conversation

[oorjitchowdhary]

Yeah.. Feels good to have contributed by collaborating 🎉

[SidharthBansal]

@oorjitchowdhary what is the behaviour of these two remaining on the localhost:3000?

[oorjitchowdhary]

• [x] WORKING Login form validations are working fine for incorrect input fields(testing)
• [x] WORKING Login modal validations are working fine for incorrect input fields(testing)

They're working.. I mentioned

[JonathanXu1]

Wow good job guys! Honored to be part of this

[SidharthBansal]

Where are they working @oorjitchowdhary?
On the localhost or on the unstable?
Or both?

[SidharthBansal]

@oorjitchowdhary is it redirecting back to the modal or to the login page?

[SidharthBansal]

If it works on both and redirects back to the same page. then please provide the gif for the following
/questions -> login -> unsuccessful login ->must be on the /questions and modal should appear with the errors -> filled modal correctly -> logged in successfully -> at the /questions page and we are signed in.

[oorjitchowdhary]

Okay.. I'll make a GIF

[oorjitchowdhary]

So... for unstable

• [ ] Login modal validations are working fine for incorrect input fields(testing)
  You're redirected to PL login page
• [ ] Login form validations are working fine for incorrect input fields(testing)
  You're redirected to unstable PL login page with an error "There is nobody in our system by that name, are you sure you have the right username?"

[SidharthBansal]

@oorjitchowdhary I have given you reward for both login and signup modals, am I correct? I guess this work was remaining, for that issues.

[oorjitchowdhary]

Not for login but for signup..

[SidharthBansal]

Let me check your tasks on the dashboard.

[oorjitchowdhary]

Okay ..

[SidharthBansal]

https://codein.withgoogle.com/dashboard/tasks/5075926623715328/

[oorjitchowdhary]

And for localhost...

• [ ] Login modal validations are working fine for incorrect input fields(testing)
  You're redirected to login page with an error "Password is not valid"
• [ ] Login form validations are working fine for incorrect input fields(testing)
  You're redirected to login page with an error "Password is not valid"

[oorjitchowdhary]

https://codein.withgoogle.com/dashboard/tasks/5075926623715328/

Claimed it

[SidharthBansal]

OK, so I am right that we need a fix here.
Can you try this
/questions -> login -> unsuccessful login ->errors on the login page-> filled login form correctly -> logged in successfully -> at the /questions page and we are signed in.

[oorjitchowdhary]

@SidharthBansal This for localhost right?

[SidharthBansal]

right

On Sun, Dec 9, 2018 at 11:10 PM Oorjit Chowdhary [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal This for localhost
right?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4210#issuecomment-445556593,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ9zUPS-V7FEsg_UfAHSLaSRincNjks5u3UsEgaJpZM4ZKLht
.

[oorjitchowdhary]

ok

[oorjitchowdhary]

/questions -> login -> unsuccessful login ->errors on the login page-> filled login form correctly -> logged in successfully -> at the /questions page and we are signed in.

Yes this works...

[SidharthBansal]

gif please. Once you give me the gif please claim it so that I can approve
it

On Sun, Dec 9, 2018 at 11:13 PM Oorjit Chowdhary [e-mail]
wrote:

/questions -> login -> unsuccessful login ->errors on the login page->
filled login form correctly -> logged in successfully -> at the /questions
page and we are signed in.

Yes this works...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4210#issuecomment-445556789,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ2GY5aDgUGCj30vJ-Tj5ZT3Uj2eGks5u3UutgaJpZM4ZKLht
.

[oorjitchowdhary]

Okay sure

[oorjitchowdhary]

[SidharthBansal]

Hurray!!!

[SidharthBansal]

Please claim it and get rewards

[oorjitchowdhary]

https://codein.withgoogle.com/dashboard/task-instances/4793116046393344/
This is the one right?

[SidharthBansal]

yes

On Sun, Dec 9, 2018 at 11:27 PM Oorjit Chowdhary [e-mail]
wrote:

https://codein.withgoogle.com/dashboard/task-instances/4793116046393344/
This is the one right?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4210#issuecomment-445557802,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ55Tsxjidq-tRMw69sTjiWIQLBgBks5u3U7sgaJpZM4ZKLht
.

[oorjitchowdhary]

I've claimed it

[SidharthBansal]

Please sent it for review also. You missed it.

[SidharthBansal]

I know you are careful, but please be a little more.

[oorjitchowdhary]

Oh I think @jywarren approved it.. 😄
That's why you may not be able to see it

[oorjitchowdhary]

[SidharthBansal]

Oh great @jywarren is back happy to see him.

On Sun, Dec 9, 2018 at 11:35 PM Oorjit Chowdhary [e-mail]
wrote:

[image: image]
https://user-images.githubusercontent.com/39333058/49700915-22979780-fc0b-11e8-89cd-dfd49f038959.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4210#issuecomment-445558441,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQz7LckN7M32-J5IFpv3013JubeOAks5u3VD8gaJpZM4ZKLht
.

[kevinzluo]

I recently opened the console, causing the window width to shrink and an error like this occured:

When the window gets even smaller it is fixed, but in a certain interval the input fields are too long.

[JonathanXu1]

@kevinzluo do you think it's similar to this?
https://github.com/publiclab/plots2/issues/3454#issuecomment-445715574

[SidharthBansal]

@kevinzluo please claim the task
https://codein.withgoogle.com/dashboard/tasks/5255181143900160/
As you have find a bug.
Jonathan you are working this task instance is two. You can also take it after making separate issue for your above comment. You both will get credits for the bug.

On Mon, Dec 10, 2018, 1:14 PM Jonathan Xu <[email protected] wrote:

@kevinzluo https://github.com/kevinzluo do you think it's similar to
this?

3454 (comment)

https://github.com/publiclab/plots2/issues/3454#issuecomment-445715574

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4210#issuecomment-445720130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQzDrkc5gU25JAnTLVQl8pE3aUqynks5u3hDTgaJpZM4ZKLht
.

[SidharthBansal]

Both of you are requested to open up a new issue for reported bugs and then submit the issue links in the GCI platform so that you can get points.
Please hide these comments from both of these issues to make the conversation nice.
When ever you encounter bug not related to Amy issue please open up a new issue.

[JonathanXu1]

@SidharthBansal how's this? #4245

[SidharthBansal]

Reviewing it there.

[SidharthBansal]

@JonathanXu1 please take https://codein.withgoogle.com/dashboard/tasks/5255181143900160/. Your reward is pending.

[SidharthBansal]

Shifted to #4250