Plots2: Change frontend for Comments

[SidharthBansal]

Currently, the post action of comments looks as

we want it to change it to the following

In this issue we just want a grey div in background.
radio buttons are linked to all the tags of the note.
Refer #3932.

[SidharthBansal]

We are also looking for the placeholder text.

[oorjitchowdhary]

I'll take this up..

[oorjitchowdhary]

Can you tell if the grey div comment has been implemented anywhere yet?

[SidharthBansal]

I'll take this up..

Great!!!

Can you tell if the grey div comment has been implemented anywhere yet?

I don't think it is implemented yet.

On Sun, Dec 9, 2018 at 4:06 PM Oorjit Chowdhary [e-mail]
wrote:

Can you tell if the grey div comment has been implemented anywhere yet?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4204#issuecomment-445526434,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ5azBPNHAmtV1An4KNSatX1oP-5zks5u3OfCgaJpZM4ZKCw_
.

[oorjitchowdhary]

Ok

[oorjitchowdhary]

@SidharthBansal could you help me with the code file.. I'm unable to find the template

[SidharthBansal]

https://github.com/publiclab/plots2/blob/master/app/views/comments/_form.html.erb?fbclid=IwAR37Nyungallfv1jsAtvrNuVIlBT9Uxf3TGZONNkWXMCkvjPzS24qLc0fRs#L56

On Sun, Dec 9, 2018 at 4:32 PM Oorjit Chowdhary [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal could you help me
with the code file.. I'm unable to find the template

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4204#issuecomment-445527869,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ2yn0rOwi1CXYdwP3P_N9VfWY5aFks5u3O27gaJpZM4ZKCw_
.

[SidharthBansal]

@oorjitchowdhary I can't see claim on the task. Please send the patch and claim it.

[digitaldina]

@oorjitchowdhary I see that you are focused on working on other tasks and have not claim this one. I hope it's OK that I did :)

[vatbq]

@dinaelhanan Did you finish this? I can help you if you want :)

[SidharthBansal]

Dinael is working on this great

[digitaldina]

@SidharthBansal side note: my name is Dina, but thanks so much!

[SidharthBansal]

Valentina can also get credits in case she reviews it so that all work can be completed

[vatbq]

Her name is Dina hahaha, I also got confused @SidharthBansal
@dinaelhanan Great, I just wanted to help :)

PD: Dina, I left a comment there

[SidharthBansal]

Really sorry.

On Mon, Dec 10, 2018, 7:57 AM Valentina Tironi <[email protected]
wrote:

Her name is Dina hahaha, I also got confused @SidharthBansal
https://github.com/SidharthBansal
@dinaelhanan https://github.com/dinaelhanan Great, I just wanted to
help :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4204#issuecomment-445633347,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ-CMeiCdLbiuPluglflodtZ-CEhcks5u3cadgaJpZM4ZKCw_
.

[vatbq]

@SidharthBansal are you free? I have some pulls to review and would be great if you check out them :) ((Sorry for asking you here :p))

https://github.com/publiclab/plots2/pull/4217
https://github.com/publiclab/plots2/pull/4219

[SidharthBansal]

Please tag my name in your PRS. In case I will be able to help on those
tasks I will for sure.

On Mon, Dec 10, 2018, 8:01 AM Valentina Tironi <[email protected]
wrote:

@SidharthBansal https://github.com/SidharthBansal are you free? I have
some pulls to review and would be great if you check out them :) ((Sorry
for asking you here :p))

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4204#issuecomment-445634336,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ6vmlDyp89i9GqpXQZR6ZFnFR4dZks5u3cdkgaJpZM4ZKCw_
.