Plots2: More than 1 reactions on a comment

[arungoel123456]

If we have reacted once on a comment , then we can add another reaction on a comment .... For eg

In this we can see that we can thumbs up as well as we can thumbs down at the same moment .. And at the same time we can react with heart as well ..... How .... This needs to be resolved .... And I would like to work on it

[oorjitchowdhary]

@arungoel123456 That's a great catch.. but I think we should edit the code in a manner that a particular user can use only one reaction once.. for eg.. a thumbs up can be used only once by a user.. but he may also add other reactions.. but all reactions can be put up only once.. sort of how it's like on github.. I'll make a gif to demonstrate it well...

[oorjitchowdhary]

See how it works on github..
@publiclab/mentors Can help us out here maybe

[SidharthBansal]

@arungoel123456 are you a gci student, if yes please claim the give suggestions task.
Nice catch.
Thank @arungoel123456
Are you willing to submit a fix for it?

[arungoel123456]

@SidharthBansal who is a gci student ... please explain .
Secondly I am ready to fix this

[arungoel123456]

@oorjitchowdhary if we give a thumbs up , it means we liked it but if we are also able to give thumbs down at the same time with thumbs up , what do we actually mean by doing that .... are we liking it or disliking it .... I hope u will get it what I am trying to say .

[oorjitchowdhary]

@SidharthBansal who is a gci student ... please explain .
Secondly I am ready to fix this

GCI is short for Google Code-in - an annual competition organized by Google for 13-17 year olds

[oorjitchowdhary]

@oorjitchowdhary if we give a thumbs up , it means we liked it but if we are also able to give thumbs down at the same time with thumbs up , what do we actually mean by doing that .... are we liking it or disliking it .... I hope u will get it what I am trying to say .

Yes, I get your point.. I just noticed this error on github too..
So perhaps we could change our emoji system to one reaction per user...

[SidharthBansal]

Arun go ahead!
Best of luck

On Sun, Dec 9, 2018 at 3:18 PM Oorjit Chowdhary [e-mail]
wrote:

@oorjitchowdhary https://github.com/oorjitchowdhary if we give a thumbs
up , it means we liked it but if we are also able to give thumbs down at
the same time with thumbs up , what do we actually mean by doing that ....
are we liking it or disliking it .... I hope u will get it what I am trying
to say .

Yes, I get your point.. I just noticed this error on github too..
So perhaps we could change our emoji system to one reaction per user...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4202#issuecomment-445523813,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQzmkegiiCEoBpahxLl4a81nCY0qTks5u3NxugaJpZM4ZJ_JD
.

[arungoel123456]

@SidharthBansal Thank u so much .... I am not a gci student .... I am starting to work on this issue

[arungoel123456]

@oorjitchowdhary Ok i will try to fix it .... Thank u

[SidharthBansal]

No problem. Organisation is open to all.

On Sun, Dec 9, 2018 at 5:55 PM Arun Goel [e-mail] wrote:

@SidharthBansal https://github.com/SidharthBansal Thank u so much ....
I am not a gci student .... I am starting to work on this issue

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4202#issuecomment-445533237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ8sgf0chvMBAnfH1jI5796uUXWoMks5u3QFAgaJpZM4ZJ_JD
.

[arungoel123456]

@SidharthBansal I think I have corrected the code .... Can u please tell how to give a pull request

[jywarren]

Hi, Arun - i think there could be more reasons for someone to use multiple
reactions than there are problems with +1 and -1 at the same time. Maybe
someone is saying that there are both good and bad things about a comment?

However, one thing I'd like to suggest is that once there is one reaction,
could we have a second button to add reactions appear next to the row of
reactions, as it does on GitHub? That way there's a faster spot to access
them?

Would you mind taking on that project instead of the "only one reaction per
person" one -- that way we can stay more consistent with GitHub UI? Thanks!

On Sun, Dec 9, 2018 at 1:49 AM Oorjit Chowdhary [e-mail]
wrote:

[image: morethan1rectionsonacommen]
https://user-images.githubusercontent.com/39333058/49694708-fb15e000-fbb4-11e8-8649-1a5ed5718195.gif

See how it works on github..
@publiclab/mentors https://github.com/orgs/publiclab/teams/mentors Can
help us out here maybe

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4202#issuecomment-445517842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5OH_80KfXi79NXHEWiWlJl0CVCiks5u3MB_gaJpZM4ZJ_JD
.

[arungoel123456]

@jywarren I got what u want to say in the first para , but i didnt get what u wanna say in second para and which project do u want me to take up ....

I think we should make it like facebook where each person can react only once . Giving a ThumbsUp and ThumbsDown at the same time would not give us the clarity wether the comment is worth reading or not . So I think we should make it one reaction per comment

[jywarren]

Actually the GitHub convention is for multiple, and we often use more than
one response -- so I'd like to preserve this, as it's useful. Try reacting
on GitHub and you'll see how it also presents a row of reactions, then a +
button in the same row for a quick addition of more reactions!

On Mon, Dec 10, 2018 at 9:12 AM Arun Goel [e-mail] wrote:

@jywarren https://github.com/jywarren I got what u want to say in the
first para , but i didnt get what u wanna say in second para and which
project do u want me to take up ....

I think we should make it like facebook where each person can react only
once . Giving a ThumbsUp and ThumbsDown at the same time would not give us
the clarity wether the comment is worth reading or not . So I think we
should make it one reaction per comment

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4202#issuecomment-445849868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ7Vabjz9W3Gdmsvx79xwyQmx7ljmks5u3nnbgaJpZM4ZJ_JD
.

[vatbq]

What are we going to do with this? I think that is fine that you can add more than one reaction

[digitaldina]

@ValentinaTironi @jywarren I agree. I like being able to use multiple ones to show how I feel about a comment ; )

[jywarren]

OK, I"m going to go ahead and close this as I think enough people want to be able to respond multiple times. Thank you!!!