Plots2: Styling missing on 2nd page of comments on profile

[jywarren]

This looks like the layout is being suppressed in the user_controller!

https://publiclab.org/profile/comments/423961?page=4

[oorjitchowdhary]

I think the first comments page loads on the normal /profile page so it has the styles but rest all are empty..
I think we can use the same styles here as I did in my PR #4143 ..

[SidharthBansal]

I agree with @oorjitchowdhary we should use same styles.
@oorjitchowdhary are you willing to take this?

[oorjitchowdhary]

Yes.. I'll do this.. Could I just get a pointer on the code file of this.. Thanks

[jywarren]

Oh, i think the styles already exist, this page is just getting rendered
without a layout, so it misses the CSS links and beginning and end of the
page HTML. Maybe check in the profile action in the user_controller to
see if you can find it saying layout: false for anything?

On Fri, Dec 7, 2018 at 2:46 PM Oorjit Chowdhary [e-mail]
wrote:

I think the first comments page loads on the normal /profile page so it
has the styles but rest all are empty..
I think we can use the same styles here as I did in my PR #4143
https://github.com/publiclab/plots2/pull/4143 ..

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4174#issuecomment-445344507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ1G_BymJsDeeZkb852TvpbcNjjhxks5u2sVpgaJpZM4ZJBlL
.

[oorjitchowdhary]

https://github.com/publiclab/plots2/blob/4a2596343a5f0199798313b6878f622fbc7e2953/app/controllers/users_controller.rb#L218
I found this.. not sure if its related

[oorjitchowdhary]

@SidharthBansal @jywarren

[jywarren]

That's the kind of "no format" that causes this, but that one is for the
RSS feeds. Maybe could be good to use the Google Dev console to see exactly
what request is sent when this page is loaded, locally. Then we could try
to figure out why it's not rendering a layout. Thanks!

On Sat, Dec 8, 2018 at 1:28 PM Oorjit Chowdhary [e-mail]
wrote:

>

https://github.com/publiclab/plots2/blob/4a2596343a5f0199798313b6878f622fbc7e2953/app/controllers/users_controller.rb#L218
I found this.. not sure if its related

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4174#issuecomment-445483708,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2pBV0vqX8pXDJviN4vq3HK7mbBNks5u3BKogaJpZM4ZJBlL
.

[oorjitchowdhary]

Can anyone else take this..
Sorry, I'm unable to find a fix for this..

[madeofhuman]

I can look at this.

[grvsachdeva]

@madeofhuman that would'be great. Thanks!

[madeofhuman]

@jywarren, @gauravano I've raised a PR for this. Could you please go through it and tell me if it's how it's supposed to work? Thanks.