Plots2: Suggestion: Follow people on Public Lab
Many websites allow users to follow each other and form web. By this people will be able to know what their friends are doing. @ebarry @jywarren @publiclab/mentors what do you suggest?
SidharthBansal
All 17 comments
Yes, I think that's a great idea.. We've follow for tags and that is used widely... I think we should implement follow for people too..
oorjitchowdhary
on 7 Dec 2018
@oorjitchowdhary This issue need not be implemented until @jywarren @ebarry agrees upon it.
SidharthBansal
on 7 Dec 2018
@gauravano @jywarren is this functionality already made?
I could not find it.
SidharthBansal
on 20 Dec 2018
I would like to work on this issue. I have a rough idea of how this can be implemented! We can discuss this further! Thank you!
shubhscoder
on 22 Dec 2018
Hi @shubhscoder we need to first take input from @jywarren whether this issue needs to be further explored or not. He is right now busy, you can work on other issues if you want.
Thanks @shubhscoder
SidharthBansal
on 22 Dec 2018
Much of the following code is named ----Selection - like NodeSelection for liking nodes, TagSelection for following tags. We have a UserSelection area but I don't know if it's hooked up to work!
https://github.com/publiclab/plots2/search?q=UserSelection
Looks like not! Most of the code is here:
It doesn't really look like it was ever built out: https://github.com/publiclab/plots2/commits/5c0d96274bd0be15feba69d8f30093082402ace5/app/models/user_selection.rb
But if you search for the TagSelection and NodeSelection code, you can see how they are set up. I hope that helps! We'd have to modify the notify methods to ensure we are notifying everyone, but not more than once. That code is pretty thoroughly tested so we should be able to monitor carefully what new code does to change the behavior.
jywarren
on 22 Dec 2018
Much of the following code is named ----Selection - like NodeSelection for liking nodes, TagSelection for following tags. We have a UserSelection area but I don't know if it's hooked up to work!
https://github.com/publiclab/plots2/search?q=UserSelection
Looks like not! Most of the code is here:
It doesn't really look like it was ever built out: https://github.com/publiclab/plots2/commits/5c0d96274bd0be15feba69d8f30093082402ace5/app/models/user_selection.rb
But if you search for the TagSelection and NodeSelection code, you can see how they are set up. I hope that helps! We'd have to modify the notify methods to ensure we are notifying everyone, but not more than once. That code is pretty thoroughly tested so we should be able to monitor carefully what new code does to change the behavior.
jywarren
on 22 Dec 2018
Oh this is really cool. We have another project to work upon. Let's start this up.
@shubhscoder as per https://github.com/publiclab/plots2/issues/4164#issuecomment-449560828 please go ahead.
Thanks everyone!!!
SidharthBansal
on 22 Dec 2018
Thank you so much! I am starting now !
On Sat, Dec 22, 2018, 5:43 PM Sidharth Bansal notifications@github.com
wrote:
Oh this is really cool. We have another project to work upon. Let's start
this up.
@shubhscoder https://github.com/shubhscoder as per #4164 (comment)
https://github.com/publiclab/plots2/issues/4164#issuecomment-449560828
please go ahead.
Thanks everyone!!!—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4164#issuecomment-449565972,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARofxYzuM5qAMpkVFYryWeW7G98nktiUks5u7iH3gaJpZM4ZHmZw
.
shubhscoder
on 22 Dec 2018
@SidharthBansal
I think this feature is already implemented. I have attached some screenshots regarding the same!
shubhscoder
on 23 Dec 2018
So, users can follow each other. Are they getting any notifications regarding their followers?
If a person is following someone then they must get the notifications. Can you please check this?
We are currently having email notification system at PL.
SidharthBansal
on 23 Dec 2018
Ok I will check that out !
On Sun, Dec 23, 2018, 4:20 PM Sidharth Bansal notifications@github.com
wrote:
So, users can follow each other. Are they getting any notifications
regarding their followers?
If a person is following someone then they must get the notifications. Can
you please check this?
We are currently having email notification system at PL.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4164#issuecomment-449628289,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARofxR5e0K9O_GdpaEr_w0Ap0p929mpHks5u71_agaJpZM4ZHmZw
.
shubhscoder
on 23 Dec 2018
@SidharthBansal The notification system has not been implemented. I will start working on that now. Thank you!
shubhscoder
on 24 Dec 2018
Great!!!
On Mon, Dec 24, 2018, 1:10 PM Shubham Sangamnerkar <[email protected]
wrote:
@SidharthBansal https://github.com/SidharthBansal The notification
system has not been implemented. I will start working on that now. Thank
you!—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4164#issuecomment-449697856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ5KNF0ixK-48mbBmVfM7Gmqi0818ks5u8ITrgaJpZM4ZHmZw
.
SidharthBansal
on 24 Dec 2018
This one is interesting. @shubhscoder let me know if you need any help. Thanks!
grvsachdeva
on 26 Dec 2018
@gauravano I have made a PR for this. Can you please check if everything is good or we need some more additions? Thank you so much!
shubhscoder
on 27 Dec 2018
I believe this is now implemented, and am closing, but if folks could test it out that would be great! #6190
jywarren
on 27 Sep 2019
Related issues
shapironick
·
3Comments
grvsachdeva
·
3Comments
keshavsethi
·
3Comments
divyabaid16
·
3Comments
milaaraujo
·
3Comments
Most helpful comment
@SidharthBansal The notification system has not been implemented. I will start working on that now. Thank you!