We have a great subscription system now. Let's come up with some better, smarter, and smoother ways to encourage people to subscribe (without just making BIG SIGNS EVERYWHERE). Ideas:
@IshaGupta18 are you familiar with creation of first timer only
issues. Have you created any so far?
We will creating first timers issues for the following:
This means this whole project is going to be done by first timers. Isn't this amazing @jywarren?
I will try my level best to increase our community as much as I can. :tada: :100:
No, I am not very familiar with making first timers! I am very happy at this growth! Very well done @SidharthBansal !
@jywarren @SidharthBansal i would love to work on this. please guide me
thank you
Yes, you can guide me too on how to make ftos once we are done with the main PR, then we can work on this and make ftos, will that be okay? @SidharthBansal
Here is template to ftos.
https://docs.google.com/document/d/1dO-CAgModEGM5cOaMmcnBh2pEON0hv_rH3P2ou2r1eE/edit
You can use this template to write first timer only
issues. A conversation will be here if you face problem in creating them.
Step 1: @IshaGupta18 please add button next to the topics sections in a Pull Request
. I want to see number of lines of code.
Step 2: @IshaGupta18 you can add subscribe button next to tags shown on the blog page. Can you create fto for this once we complete #4626.
Step 3: @geekychaser once @IshaGupta18 completes her fto creation. You can add a button next to topics on the dashboard.
Step 4: @geekychaser create a fto for remaining issues listed above.
Let's do this much first
Absolutely!
@IshaGupta18 please read it once more. I need to edit it due to some reasons. Sorry
@IshaGupta18 let's have a quick pr merge for the Subscription button next to Topics on the dashboard as per https://github.com/publiclab/plots2/issues/4131#issuecomment-454542075
Please merge the latest master(#4626) into your master and make a new branch for these changes.
Yes I will do it. Can I do it tomorrow? It's 3 am and I have college in the morning, I hate to complain about it but I think I should sleep. Will that be okay?
Yeah sure.
Thanks a lot. I am so looking forward to this and creating fto for this issue!
Please use emoticons(:+1: ) from next time. We want shorter conversations.
Actually I am facing some problem here. The "Topics" panel is being fetched through a helper using caching in the code and I am unable to get how to access that view, so that I can render my button partial there. Could you please guide me with that?
It is always better to tell the permalink than sending screenshots. Please
provide it so that mentor can help you.
You have to display the button next to the Topic
text. So, search for
topic text.
On Thu, Jan 17, 2019 at 6:28 PM Isha Gupta notifications@github.com wrote:
Actually I am facing some problem here. The "Topics" panel is being
fetched through a helper using caching in the code and I am unable to get
how to access that view, so that I can render my button partial there.
Could you please guide me with that?[image: image]
https://user-images.githubusercontent.com/40794215/51320415-b750a900-1a85-11e9-864f-278c8d193e43.png—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4131#issuecomment-455163385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ95w8afEN0z14hlduEWldKyVk9B1ks5vEHOOgaJpZM4ZEmIR
.
Yes actually, this isn't like a normal view here, the view is being rendered through cache, from an entry in the database, here are the links:
https://github.com/publiclab/plots2/blob/9f7cfc47ded41ed3a7370c66a9c4f7af9704af59/app/views/sidebar/_dashboard.html.erb#L38-L41
So the view is rendered from the database's entry. Does this make sense?
I think we can add the button next to line 41 in plots2/app/views/sidebar/_dashboard.html.erb.
What should I pass as tags variable here then? Like @node.node_tags, what will come here?
Please leave this issue until Jeff replies on it.
You can send a PR for the blog page.
So I am inserting the button here, is this right? Should I make a PR for it?
Make it next to read more text.
Yes make a PR.
On Fri, Jan 18, 2019, 2:11 AM Isha Gupta <[email protected] wrote:
So I am inserting the button here, is this right? Should I make a PR for
it?[image: image]
https://user-images.githubusercontent.com/40794215/51347552-6ad98d80-1ac6-11e9-82e6-6e31a1974707.png[image: image]
https://user-images.githubusercontent.com/40794215/51347534-5e553500-1ac6-11e9-8d46-9eb3e4bd3368.png—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4131#issuecomment-455324602,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ6Ylp_vkTa58Io6b7ehonOJQAa8wks5vEOAXgaJpZM4ZEmIR
.
Once you complete your PR. Then please try "trending tags on dashboard". Don't commit changes. Use the fto template given above to create a fto. You can see other ftos for reference.
@IshaGupta18 can you please link the first timers only
issue number here.
created #4667 for /tags
@SidharthBansal I guess we have covered all the related issue ?
Please correct me if i am wrong.
Thank you
I think one issue is left. Trending tags.
On Sat, Jan 19, 2019, 2:37 PM Rishabh Bothra <[email protected]
wrote:
@SidharthBansal https://github.com/SidharthBansal I guess we have
covered all the related issue ?
Please correct me if i am wrong.
Thank you—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4131#issuecomment-455762712,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ7CSH-qXrKf5GsQGwN1LN_jctGRoks5vEuBMgaJpZM4ZEmIR
.
@SidharthBansal So we need to have this subscribe button on our dashboard ?
Yes
On Sat, Jan 19, 2019, 3:10 PM Rishabh Bothra <[email protected]
wrote:
@SidharthBansal https://github.com/SidharthBansal So we need to have
this subscribe button on our dashboard ?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4131#issuecomment-455764816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ88R2WTtlvrSBkfG_M5t5HrR3mG_ks5vEuf1gaJpZM4ZEmIR
.
Can I do this please since it was assigned to me? @SidharthBansal
@geekychaser we'll assign you more ftos but kindly let me create this one because it was assigned to me initially
Yeah you can do it. @geekychaser is just helping you here, I guess. Isha
can create the fto and in case she will require help then Rishabh can do so.
Once Isha you post the fto, please close this issue.
Thanks all.
On Sat, Jan 19, 2019, 3:36 PM Isha Gupta <[email protected] wrote:
@geekychaser https://github.com/geekychaser we'll assign you more ftos
but kindly let me create this one because it was assigned to me initially—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4131#issuecomment-455766737,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ9sXU3EQV9BgN3jBzn7fQ5V6f9u0ks5vEu5AgaJpZM4ZEmIR
.
@IshaGupta18 I know, that you are creating ftos but this is your first fto so i was trying to help you in fto creation.
thank you
Great folks. We really appreciate Rishabh your kind gesture to help Isha
On Sat, Jan 19, 2019, 3:48 PM Rishabh Bothra <[email protected]
wrote:
@IshaGupta18 https://github.com/IshaGupta18 I know, that you are
creating ftos but this is your first fto so i was trying to help you in fto
creation.
thank you—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4131#issuecomment-455767494,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQzl1aCtPurSj73EY7kaxuSs0xU-jks5vEvEGgaJpZM4ZEmIR
.
Yes I really appreciate your kind gesture @geekychaser . Thank you for your support everyone!
I have created #4671 for trending topics. I think this issue can be closed now. Where all should we add this button now? Any suggestions apart from the ones for which ftos have been created?
Have you checked it before creating the fto that it works perfectly fine?
I checked each page. There are no more places where we can add the buttons. In case, you will find it please create a fto for it.
We can close this issue.
@jywarren we have successfully completed this Multiple Tag Subscription Project with help of @IshaGupta18 and @geekychaser :tada: :100: :1st_place_medal:
If anything is left in the project please feel free to reopen the issue and comment some suggestions.
Fantastic work, everyone!!!!
On Sun, Jan 20, 2019, 5:15 AM Sidharth Bansal <[email protected]
wrote:
@jywarren https://github.com/jywarren we have successfully completed
this Multiple Tag Subscription Project with help of @IshaGupta18
https://github.com/IshaGupta18 and @geekychaser
https://github.com/geekychaser 🎉 💯 🥇
If anything is left in the project please feel free to reopen the issue
and comment some suggestions.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4131#issuecomment-455846237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ06LP-ZylhcmQLjLJYd3AaUNy4Nbks5vFCWKgaJpZM4ZEmIR
.
Most helpful comment
Great folks. We really appreciate Rishabh your kind gesture to help Isha
On Sat, Jan 19, 2019, 3:48 PM Rishabh Bothra <[email protected]
wrote: