Plots2: Move .yahoo_quoted class checking to new function

[namangupta01]

Here, we are checking for the presence of .yahoo_quoted https://github.com/publiclab/plots2/blob/ff870dea11781ab5ed50a806a55f362210f3a638/app/models/comment.rb#L300
We can improve this by moving this checking into the new function just like we have for gmail.
https://github.com/publiclab/plots2/blob/ff870dea11781ab5ed50a806a55f362210f3a638/app/models/comment.rb#L291

[digitaldina]

I will take this!
Please add to GCI dashboard!

[SidharthBansal]

Published on the GCI dashboard.
Please claim it before anyone else claims it.
Thanks

[namangupta01]

@SidharthBansal where is the pull request for this?

[SidharthBansal]

Sorry. Put label in wrong issue.

[SidharthBansal]

No one is currently working on this issue

[digitaldina]

changed my mind... see below comment :)

[digitaldina]

@SidharthBansal I will take this once I get this GCI task approved: https://codein.withgoogle.com/dashboard/task-instances/4824240835526656/

[digitaldina]

@namangupta01 what do you mean by moving it to a new function? I see that it is inside a function just like the gmail one here :
https://github.com/publiclab/plots2/blob/ff870dea11781ab5ed50a806a55f362210f3a638/app/models/comment.rb#L299

[grvsachdeva]

Hi @dinaelhanan, what @namangupta01 meant is creating a new function named yahoo_quote_present? which would be similar in working to Gmail's function mentioned here- https://github.com/publiclab/plots2/issues/4112#issue-387058086

The goal is to replace the line https://github.com/publiclab/plots2/blob/ff870dea11781ab5ed50a806a55f362210f3a638/app/models/comment.rb#L300 with the function.

Let us know if you want further details. Thanks!

[kimcheung]

Looks like this is still open, can I take it?

[kimcheung]

PR posted https://github.com/publiclab/plots2/pull/8640