Plots2: Activity prompt buttons on Thumbnail grids

[jywarren]

We have some great new features by @ValentinaTironi -- a thumbnail grid -- see the Activities section of https://publiclab.org/micro 👍

One thing that would be great is to have the built-in buttons below that we see on non-thumbnail Activity grids, such as at https://publiclab.org/coqui

Here is the code that auto-generates the button and notice:

https://github.com/publiclab/plots2/blob/e400bf711b6f432051d61be2d912476d55de7ca3/app/views/grids/_notes.html.erb#L66-L73

I think we could break it into a partial template and also include it into the new thumbnail template, so we don't have redundant code:

https://github.com/publiclab/plots2/blob/master/app/views/grids/_thumbnail.html.erb

We'd love help with this and it could become a GCI task too!

[vatbq]

If I can help something, don't hesitate to ask me!

[oorjitchowdhary]

Impressive work there, @ValentinaTironi

[oorjitchowdhary]

One thing that would be great is to have the built-in buttons below that we see on non-thumbnail Activity grids, such as at https://publiclab.org/coqui

@jywarren I'm unable to understand this...

[vatbq]

I think he is trying to say that now doesn't exist a button to create notes in thumbnail grid like in others grids.
For example, here, in the questions grids there is an ask a question button

@jywarren Am I right?
@oorjitchowdhary Hope this helps you!

[jywarren]

yes, exactly! thanks!!!

On Sat, Dec 1, 2018 at 1:52 PM Valentina Tironi [e-mail]
wrote:

I think he is trying to say that now doesn't exist a button to create
notes in thumbnail grid like in others grids.
For example, here, in the questions grids there is an ask a question
button

[image: screen shot 2018-12-01 at 3 49 32 pm 1]
https://user-images.githubusercontent.com/20969831/49331732-c389b100-f580-11e8-9ff2-287f4c04384c.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4092#issuecomment-443449030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0KjGtyu3Y-QmdCC0d8ZFJGE_bHwks5u0s_dgaJpZM4Y9An_
.

[oorjitchowdhary]

I can see add an activity button in the thumbnail grid too.. Just the same as in the other non-thumbnail grids..
So do we want to add ask a question too?

[oorjitchowdhary]

@publiclab/reviewers ?

[vatbq]

Sorry for the delay! About your question: I don't see it locally

Try create one in your project and let me know if the button appears!
@oorjitchowdhary

[jywarren]

Yes, i added that button manually! Sorry to confuse you, but we want it
added automatically as in prior types of grids. Thanks!

On Thu, Dec 6, 2018 at 5:36 PM Valentina Tironi [e-mail]
wrote:

Sorry for the delay! About your question: I don't see it locally

[image: screen shot 2018-12-06 at 7 20 27 pm]
https://user-images.githubusercontent.com/20969831/49615774-549bc600-f98d-11e8-89ce-731ecbf70b76.png

Try create one in your project and let me know if the button appears!
@oorjitchowdhary https://github.com/oorjitchowdhary

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4092#issuecomment-445055175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ10V0Xh4TPZXC4p3ZRZDksVa-PdFks5u2ZvPgaJpZM4Y9An_
.

[vatbq]

@oorjitchowdhary are you still working on this?

[oorjitchowdhary]

Okay.. I'll open a PR in a while..

[oorjitchowdhary]

@jywarren How can I make a thumbnail grid like this on localhost? After making a wiki page..

[jywarren]

You can make a new wiki page, and add the text "[notes:grid:test]" to a new
line in there, and save. That should work!

On Fri, Dec 7, 2018 at 12:25 PM Oorjit Chowdhary [e-mail]
wrote:

@jywarren https://github.com/jywarren How can I make a thumbnail grid
like this on localhost? After making a wiki page..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4092#issuecomment-445304410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ05N6tkUk3e6HXmJ2FPsNEHpfsX3ks5u2qSBgaJpZM4Y9An_
.

[oorjitchowdhary]

Okay thanks

[oorjitchowdhary]

That doesn't work @jywarren

[jywarren]

what do you see? You can see examples of thumbnail grids at
https://publiclab.org/micro for reference!

On Fri, Dec 7, 2018 at 12:46 PM Oorjit Chowdhary [e-mail]
wrote:

That doesn't work @jywarren https://github.com/jywarren

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4092#issuecomment-445310237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ1fk2qqCtca_jty-sH0TgR2dtL_gks5u2qk-gaJpZM4Y9An_
.

[oorjitchowdhary]

When I use [notes:grid:test], nothing comes up.. it simply prints this on the page

[jywarren]

Perhaps you don't have any notes tagged with test?

[oorjitchowdhary]

Nope, i have it.. 2 of them actually

[jywarren]

what is the exact plaintext content on your wiki page?

On Fri, Dec 7, 2018 at 1:05 PM Oorjit Chowdhary [e-mail]
wrote:

Nope, i have it.. 2 of them actually

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4092#issuecomment-445315769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ3QIGtX1SlY8QUQH2v6tyT6Hjokfks5u2q3HgaJpZM4Y9An_
.

[oorjitchowdhary]

@jywarren I figured out that one but I'm stuck on another error... 😭

[oorjitchowdhary]

This is happening when I try to create a new partial template..

[jywarren]

Hmm, can you point at your latest code in a commit? Even if you need to
open a new PR to share it? Thanks!

On Fri, Dec 7, 2018 at 1:34 PM Oorjit Chowdhary [e-mail]
wrote:

This is happening when I try to create a new partial template..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4092#issuecomment-445324097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5E1kZP7O8rFX47iqH9gZf8sdVdFks5u2rShgaJpZM4Y9An_
.

[oorjitchowdhary]

Ok i will do that

[oorjitchowdhary]

@jywarren pls check out #4175

[oorjitchowdhary]

And if you've got time pls take a look at #4129 too.. Thanks