Plots2: Images distorted in thumbnail grids

[jywarren]

We have some great new thumbnail grids as shown on this page: https://publiclab.org/wiki/micro#Assembly

But as you can see, some images are distorted. This is solved in the dashboard templates -- https://github.com/publiclab/plots2/blob/master/app/views/dashboard/_node_default.html.erb#L7 and the dashboard css:

https://github.com/publiclab/plots2/blob/e6608c89b3a7d1862d1e329e377ef8aea1e2ce90/app/assets/stylesheets/dashboard.css#L199-L204

Let's apply this to the new thumbnail grids too!

@ValentinaTironi would you mind linking to the thumbnail grid code? And would you be interested in making this into a first-timers-only issue to welcome someone else into the community? I'll paste in some guidance below:

---

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

[oorjitchowdhary]

Can I take this up?

[jywarren]

Yes please!

[jywarren]

Would you like to make it into a first-timers-only issue and welcome someone else into the community?

[digitaldina]

@jywarren ^^ I think that's a good idea

[oorjitchowdhary]

@jywarren what do we want to fix here.. I'm unable to grasp it clearly..

[digitaldina]

@oorjitchowdhary good question, I don't see any distorted images either ;/

[jywarren]

The images are slightly squished -- they have not their original aspect
ratio. The CSS used on the dashboard is a little more complex, but allows
images to be shown in a fixed aspect ratio, with extra image hidden. Or, we
could just allow them to be different heights!

On Sat, Dec 1, 2018 at 9:38 AM d1g1t4ld1n4 [e-mail] wrote:

@oorjitchowdhary https://github.com/oorjitchowdhary good question, I
don't see any distorted images either ;/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4082#issuecomment-443430744,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5I0UEYXhqIvRL58YJsh6TQH10MCks5u0pRcgaJpZM4Y8GNA
.

[digitaldina]

Oh I see.. Might take this up when I've finished the unit test task. Would appreciate any help there! @jywarren

[JonathanXu1]

Would you guys need any help here?

[digitaldina]

@JonathanXu1 I think I'll take this one, once I'm done another task. If you can, check this out and see if you can help!

[digitaldina]

Tried to fixed this using the above PR, I know it's a first-timer only issue, but I haven't really touched anything that had to do with the site's design, so I hope it's OK that I took it up..! @jywarren cc @publiclab/mentors @JonathanXu1 you can take this up when I edit it, sounds good? I'll try to find way to make the issue for repetitive code really beginner friendly so we can welcome more first-timers!
I remember seeing an issue that had to do with repetitive code, but I can't find it any where. Should I open an issue? Can't wait to help people contribute!

[jywarren]

Was it perhaps #3706 ? Thank you!

[vatbq]

Hey guys! Someone needs help here?

[oorjitchowdhary]

@publiclab/mentors So is this already solved then?

[digitaldina]

I have already solved it just waiting for a task to be reviewed :) @oorjitchowdhary @ValentinaTironi

[oorjitchowdhary]

Oh okay.. Thanks for the contribution @dinaelhanan