Plots2: add login prompt to questions page

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/questions/index.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -21,14 +21,15 @@
   <div class="row">
     <div class="col-md-6">
       <h4>Ask a question here</h4>
+      <p>To ask a question, please <a href="/login?return_to=/questions">log in</a> or <a href="/signup?return_to=/questions">sign up</a> first.</p>
       <form id="questions_searchform" class="form-horizontal" role="search" autocomplete="off" action="/post">
         <div class="input-group">
-          <input tabindex="1" id="questions_searchform_input" type="text" name="title" class="form-control search-query typeahead" qryType="questions" placeholder="type your question">
+          <input tabindex="1" id="questions_searchform_input" type="text" name="title" class="<%= "disabled " if current_user %>form-control search-query typeahead" qryType="questions" placeholder="type your question">
           <input type="hidden" name="tags" value="question:general">
           <input type="hidden" name="template" value="question">
           <input type="hidden" name="redirect" value="question">
           <span class="input-group-btn">
-            <button type="submit" rel="tooltip" title="Ask a question with the entered title" class="btn btn-primary">Continue</button>
+            <button type="submit" rel="tooltip" title="Ask a question with the entered title" class="<%= "disabled " if current_user %>btn btn-primary">Continue</button>
           </span>
         </div>
       </form>

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[jywarren]

This is for @narnt, thanks!!!

It will add this prompt to the page at https://publiclab.org/questions --

[jywarren]

Please check that it looks like this once you make the changes, and upload a screenshot to the pull request you open! Thanks again!

[giordifungula]

I would like to work on it ?

[jywarren]

This one is for @narnt, apologies! @gyi2521 - thank you for your pull request, but we reserved this one for @narnt, who hasn't had a chance yet. Apologies that there are not enough first-timer issues to go around, perhaps @publiclab/mentors can create a few?

Thank you!

[jywarren]

@giordifungula @gyi2521 I created a new one here: https://github.com/publiclab/plots2/issues/3864 please chime in there to claim it, thanks!

[rdgolden]

Can I work on this PR? First timer

[jywarren]

If @narnt is willing to cede it to you, that would be OK -- i believe @narnt has completed another?

[jywarren]

and thank you all!

[narnt]

@BasedEnergy Hi! I already made one PR, so I'll try to resolve other issue, and you can take this fto issue!

[gyi2521]

Thank you, Jeffrey! Just one thing to clarify...in the previous email, you
mentioned if @narnt is willing to cede whoever claims can have it, right?
And that mean, you are going to merge the PR, right? Just want to make
sure since this is my first time... ;-)

On Wed, Oct 31, 2018 at 3:29 PM Jeffrey Warren [e-mail]
wrote:

and thank you all!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3838#issuecomment-434814414,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoIIN_-Om1U5FfG5L4HRL6j78FPX2IC_ks5uqfoxgaJpZM4YAvyr
.

[gyi2521]

It looks like @narnt just gave it @BasedEnergy... well I guess next time!
Thank you!

On Wed, Oct 31, 2018 at 4:08 PM Gina Yi [e-mail] wrote:

Thank you, Jeffrey! Just one thing to clarify...in the previous email,
you mentioned if @narnt is willing to cede whoever claims can have it,
right? And that mean, you are going to merge the PR, right? Just want to
make sure since this is my first time... ;-)

On Wed, Oct 31, 2018 at 3:29 PM Jeffrey Warren [e-mail]
wrote:

and thank you all!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3838#issuecomment-434814414,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoIIN_-Om1U5FfG5L4HRL6j78FPX2IC_ks5uqfoxgaJpZM4YAvyr
.

[jywarren]

Hi, @BasedEnergy how are you doing? Got stuck, or needed to move on to something else? We're happy to help!

[jywarren]

Maybe @gyi2521 could offer some help with the solution? Thanks all!

[imdhruvgupta]

Hi, @jywarren I am a first timer and have understood the issue and solution too. Can I offer any help here?

[SidharthBansal]

Yeah sure.

On Wed, Nov 14, 2018, 10:31 AM dhruvgupta167 [e-mail]
wrote:

Hi, @jywarren https://github.com/jywarren I am a first timer and have
understood the issue and solution too. Can I offer any help here?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3838#issuecomment-438538217,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ-NTlFl7Ewhj56bDALLOTEf4_T-kks5uu6OZgaJpZM4YAvyr
.

[imdhruvgupta]

Should I make a PR on this issue?

[SidharthBansal]

Yes

On Wed, Nov 14, 2018, 10:38 AM dhruvgupta167 [e-mail]
wrote:

Should I make a PR on this issue?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3838#issuecomment-438539370,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ1ZHekNc9k6txDg_XZJp2VsSpDZxks5uu6VZgaJpZM4YAvyr
.

[jywarren]

Yes, and there is a solution i believe in https://github.com/publiclab/plots2/pull/3847 that could be worked from! Thanks!

[akoopraba4]

I would like to work on this issue.

[SidharthBansal]

Great.

On Sun, Nov 18, 2018, 2:36 PM akoopraba4 <[email protected] wrote:

I would like to work on this issue.

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3838#issuecomment-439677973,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ5mEqCiq77ANUbkkC3rGGxmEM1O0ks5uwSMxgaJpZM4YAvyr
.

[SidharthBansal]

Please send a PR for your patches.

On Tue, Nov 20, 2018, 12:18 PM Sidharth Bansal <
bansal.[email protected] wrote:

Great.

On Sun, Nov 18, 2018, 2:36 PM akoopraba4 <[email protected] wrote:

I would like to work on this issue.

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3838#issuecomment-439677973,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ5mEqCiq77ANUbkkC3rGGxmEM1O0ks5uwSMxgaJpZM4YAvyr
.

[jywarren]

Hi, @akoopraba4 - can you title your PR descriptively so it's clear what it changes?

[akoopraba4]

Yes,I will do the necessary changes.

[akoopraba4]

Hi,
@jywarren @SidharthBansal
What should I do to make a patch file from the two commits?