Plots2: Remove the typo

Created on 22 Oct 2018  ยท  8Comments  ยท  Source: publiclab/plots2

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you ๐Ÿ’

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

๐Ÿค” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

๐Ÿ“‹ Step by Step

  • [ ] ๐Ÿ™‹ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

See this page for some help in taking your first steps!

On clicking on '?' page should be opened in new tab. Currently, it is opening on the same page. So, using target="_blank" on the <a> tag will solve the problem.

image- [ ] ๐Ÿ’พ Commit your changes

Correct the spelling of target in this file - https://github.com/publiclab/plots2/blob/master/app/views/editor/rich.html.erb#L172

  • [ ] ๐Ÿ”€ Start a Pull Request. There are two ways how you can start a pull request:
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] ๐Ÿ Done Ask in comments for a review :)

๐Ÿค”โ“ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

first-timers-only gci-candidate

Most helpful comment

I would like to claim this issue, please - I would like to practice using git in the terminal for this.

All 8 comments

Hi, this issue has been opened as a task on GCI dashboard. If you are Google Code-In participant and want to solve this issue, please claim it from Google Code-In website . Thanks!

This task is published on GCI dashboard. Thanks all.

I would like to claim this issue, please - I would like to practice using git in the terminal for this.

Hi are you a GCI student? Have you claimed this task on the GCI dashboard?

On Tue, Oct 23, 2018, 10:18 PM HarrisonLKatz notifications@github.com
wrote:

I would like to claim this issue, please - I would like to practice using
git in the terminal for this.

โ€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3737#issuecomment-432326248,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ-QhJgqgMCb2hjXP6pMqm_p2MtEnks5un0g_gaJpZM4X0Kc-
.

I have claimed this task on GCI

Yeah I can see that you are a GCI candidate
We publiclabians invite to the world of open source
Yeah you can go ahead and send us a Pull Request(that is PR in short)
Best of luck

On Tue, Oct 23, 2018, 10:18 PM Sidharth Bansal <
[email protected]> wrote:

Hi are you a GCI student? Have you claimed this task on the GCI dashboard?

On Tue, Oct 23, 2018, 10:18 PM HarrisonLKatz notifications@github.com
wrote:

I would like to claim this issue, please - I would like to practice using
git in the terminal for this.

โ€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3737#issuecomment-432326248,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ-QhJgqgMCb2hjXP6pMqm_p2MtEnks5un0g_gaJpZM4X0Kc-
.

Done! Although I did ironically make a type on the commit description (type instead of typo), the actual typo is now fixed. I believe I did the PR format right - please tell me if I made a mistake there. Thank you!

Hi @HarrisonLKatz, the typo on commit description is fine. Thanks for solving the issue! Also, if you want to contribute more, you can look for tasks on GCI dashboard or you can find issues at https://code.publiclab.org/#r=all . Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

milaaraujo picture milaaraujo  ยท  3Comments

divyabaid16 picture divyabaid16  ยท  3Comments

grvsachdeva picture grvsachdeva  ยท  3Comments

noi5e picture noi5e  ยท  3Comments

ebarry picture ebarry  ยท  3Comments