Plots2: collapse 'read more' with horizontal line in list view

Created on 12 Oct 2018 · 9Comments · Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

in https://publiclab.org/tag/ (example- code) in this page this when we see list view then read more button looks like this both (mobile/pc)
tag

📋Solution

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update Improve read more button

Code links….
https://github.com/publiclab/plots2/blob/ca114039f8551eeded2cbeec145211cc37708e2d/app/views/notes/_notes.html.erb#L49

[ ] 💾 Commit your changes

[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

CSS HTML first-timers-only good first issue help wanted

Source

avsingh999

All 9 comments

@jywarren @SidharthBansal I think we should remove list/grid view button for mobile because, in a mobile, list and grid view are same, so no need this
thanks :)

avsingh999 on 12 Oct 2018

Yeah

SidharthBansal on 12 Oct 2018

👍1

Agreed!!!!

On Sat, Oct 13, 2018, 2:26 AM Sidharth Bansal notifications@github.com
wrote:

Yeah

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3690#issuecomment-429416946,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ9LPdOORbhbIgG2dBsSKpaA5djS6ks5ukN7CgaJpZM4XZsX3
.

jywarren on 14 Oct 2018

👍1

Hi, can I work on this? I am an outreachy applicant.
UPD: sorry, I didn't see that is only for GCI.

narnt on 28 Oct 2018

Yeah sure

SidharthBansal on 29 Oct 2018

👍1

Hey @avsingh999 , is this issue still in progress ?
Does anybody else work on this one ? I'd be glad to help, thanks!

vlad-at-work on 20 Feb 2019

You can work on it.
Thanks

SidharthBansal on 20 Feb 2019

Hey @SidharthBansal I'm trying to understand what's the issue but don't quite get the description of the problem..
For example, when I'm browsing here (Chromium browser in Ubuntu 18.04) > https://publiclab.org/tag/stormwater and display the page as a list view ,I don't see the 'Read more' button displaced on the right, it's on the center below each image post.

Here's a screenshot >
listview