Plots2: Inconsistent alert for same page

Created on 30 Sep 2018  路  26Comments  路  Source: publiclab/plots2

Please describe the problem (or idea)

When we delete any comment the alert looks nice but while deleting any answer alert is the default alert.

Deleting Answer

What happened just before the problem occurred? Or what problem could this idea solve?
answer

Deleting Comment

What did you expect to see that you didn't?
comment

Please show us where to look

https://publiclab.org/questions/jradheshyam96/09-28-2018/may-i-know-more-about-how-exactly-this-will-this-work

What's your PublicLab.org username?

vikul1234

This can help us diagnose the issue:

Browser, version, and operating system

chrome, windows 10

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

design gci-candidate help wanted

All 26 comments

Thanks for opening your first issue here! Please follow the issue template to help us help you 馃憤馃帀馃槃
If you have screenshots to share demonstrating the issue, that's really helpful! 馃摳

Do you want to work on this?

yes, i want to work

Go ahead

@vikul1234 are you still working on this. If not can I work on this?

@roshniRam I am working on it.

@vikul1234 Are you still working on this. If not, can I work on this?

Go ahead

Hi Is someone working on this?
If no then I can publish this for GCI.

Okay @SidharthBansal. Please do so. 馃槃

This task is published on GCI dashboard. Thanks all.

hi, can I try?

This task is assigned for gci students. If you are gci students then you can work. Thanks

yeah sure! (:

Can you tell me where the file that needs correcting is though? I can't find it...thanks!

do I just have to add the file in which my js code in separately then?thanks!

@SidharthBansal Where is the code file which is to be corrected here? Pls help me with it.. Thanks

@oorjitchowdhary,
For comment alert (you can take the code from here)

    plots2/app/views/notes/_comment.html.erb

For answer alert (that you need to fix)

    plots2/app/views/questions/_answer.html.erb

https://publiclab.org/questions/jradheshyam96/09-28-2018/may-i-know-more-about-how-exactly-this-will-this-work
When opening this link, it says * the author of this note has been banned* and then it redirects to the public lab homepage

@oorjitchowdhary, you can use another question for testing

@publiclab/reviewers I had done this task two days ago.. But now I can't find it on the GCi dashboard now.. So is it not for gci students now?

You can see my PR #4001 which solved this issue

@oorjitchowdhary , looks like this task already solved #4010 and submitted in gci dashboard

@thesparks yeah sure but I submitted it before @valentinatironi

@oorjitchowdhary, I guess you forgot to take the task in gci and she took it earlier

Hi @oorjitchowdhary, according to GCI rules, you can perform only that tasks which you have claimed from GCI dashboard. That's why you were asked for closing PR #4001. Also, do remember this rule and open PR for only that task which you have claimed from GCI dashboard. Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

grvsachdeva picture grvsachdeva  路  3Comments

shapironick picture shapironick  路  3Comments

keshavsethi picture keshavsethi  路  3Comments

first-timers[bot] picture first-timers[bot]  路  3Comments

bronwen9 picture bronwen9  路  3Comments