Plots2: Header navbar runs out of space and covers content

[jywarren]

Our new header is very nice, but it needs to collapse a bit earlier; we use Bootstrap: https://getbootstrap.com/docs/3.3/

We should have it collapse into the "minimal" look earlier:

The code is here: https://github.com/publiclab/plots2/blob/master/app/views/layouts/_header.html.erb

This will take some testing with expanding and contracting the browser window. Please upload some screenshots of various states so we know it collapses smoothly! An animated GIF would be extra nice!

Thanks!

[shivani-kapania]

Hey! Could you please elaborate on the issue? All the header tabs need to be combined into one drop-down menu?

Thanks!

[jywarren]

Hi, if you check out how headers work in Bootstrap docs, they're pretty
clever, and can auto-collapse. But setting when this happens seems a little
more complex. See what the docs say and I'm open to proposals for
solutions! Thank you!

On Tue, Sep 25, 2018 at 12:31 PM shivani-kapania [e-mail]
wrote:

Hey! Could you please elaborate on the issue? All the header tabs need to
be combined into one drop-down menu?

Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3464#issuecomment-424409999,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJyRq3_C9xewtOS-FkDaiWCCdciRkks5uelpWgaJpZM4W4_eI
.

[DamonClark]

@jywarren I think you may need to add a css@mediarule in order to get this resolved. Although there is a chance you can make a smaller change to the _header.html.erbfile and get it working. I am happy to work on this issue, but I have a feeling its going to need some css to fix it.

[quinn-codes-synthesis]

Hi! I'd like to claim this issue.

[jywarren]

We'd love your help, thank you!

On Mon, Oct 1, 2018 at 12:27 AM Quinn [e-mail] wrote:

Hi! I'd like to claim this issue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3464#issuecomment-425786284,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ18_Q80WCVDOcuLkzxueVkzautzCks5ugZmbgaJpZM4W4_eI
.

[DamonClark]

I submitted a pull request to fix this here https://github.com/publiclab/plots2/pull/3491 with gif included. I don't know if my fix was the best way to do it. But it definitely solves the problem.

[quinn-codes-synthesis]

Thanks Damon! I think I'm in over my head, so I'm glad you were able to find a solution.

[jywarren]

@quinn-codes-synthesis -- please don't be discouraged! We're happy to open a new issue for you if you're interested. Please email me at [email protected] and I'll make one and reserve it for you. Thanks!

[DamonClark]

No worries Quinn! I'm still just learning too so I'm right there with you.

[quinn-codes-synthesis]

@jywarren -- That would be awesome. Thank you! Look for an email from me sometime early next week; I'm preparing to move this weekend and will have a lot more time to contribute once that's over with.

:house_with_garden: :truck: :derelict_house:

[jywarren]

Good luck with the move! 📦 📦 📦