Plots2: Add sorting button options to tag show template

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This will add some nice buttons to tag pages such as these: https://publiclab.org/tag/mobius

Which will allow for sorting what's displayed!

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/tag/show.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -2,11 +2,11 @@

 <div class="col-md-12">
   <%= render partial: 'tag/show/header' %>
-  
+
   <% if @tags.first && params[:id][-1..-1] != "*" %>
-    <%= render :partial => "tag/graph", locals: { tags: @tags } %>
+    <%= render partial: "tag/graph", locals: { tags: @tags } %>
   <% end %>
-  
+
   <%= render partial: 'tag/show/contributors' %>

   <% unless @tags.try(:first).try(:parent).nil? %>
@@ -20,7 +20,10 @@
   <%= render partial: "tag/show/related_tags" %>
   <%= render partial: 'tag/show/nav_tabs' %>

-  <br />
+  <p style="padding-top:8px;">
+    <a class="btn btn-sm btn-default" href="?order=views"><i class="fa fa-eye"></i> by views</a>
+    <a class="btn btn-sm btn-default" href="?order=likes"><i class="fa fa-star"></i> by likes</a>
+  </p>

   <%= render partial: 'tag/show/tab_content' %>

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[jywarren]

This will have to be merged AFTER https://github.com/publiclab/plots2/issues/3419 -- thanks!!!

[msarit]

I'd like to tackle this issue - thanks! 🙏

[jywarren]

that'd be great, however, if you've already solved a first-timers-only
issue, we ask that you consider some "candidates" or other issues you can
find on http://code.publiclab.org. Thanks!

On Tue, Sep 25, 2018 at 1:02 PM Arit Amana [e-mail] wrote:

I'd like to tackle this issue - thanks! 🙏

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3462#issuecomment-424420813,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxjacAPT-tPnXbPHjK_Ceh18Fytpks5uemGFgaJpZM4W49hY
.

[msarit]

Oh yes! I will do so - instead of hogging more first-timers issues 😂 Thanks Jeffrey.

[asiedubrempong]

I'd like to take this up as my first PR

[jywarren]

Please go ahead, @asiedubrempong !!

[asiedubrempong]

sure thanks

[RishabhBhaai]

Can I work on this issue?
I want to contribute for the first time.

[agam-kashyap]

Hey, can I try to solve this if no one is already doing it?
THANKS.

[msarit]

@RishabhBhaai are you still working on this? Please advise so that @agam-kashyap knows whether to take it up or not

[agam-kashyap]

Thank You @msarit. Please do tell @RishabhBhaai

[meinou]

Can I do it as well?

[meinou]

3833 request.

I see that it was already solved, but may be I can do it as well!
Not sure if it supposed to be in master all the time, but I think it was implied in step-by-step?

[suryanshsrivastava]

@jywarren I would like to take this up as my first PR, if it hasn't been assigned yet.

[arungoel123456]

Can i take it as my first issue

[grvsachdeva]

Closing this issue as it has been solved in #3833 but not issue wasn't closed due to missing Fixes statement in the PR. Thanks all and sorry @suryanshsrivastava @arungoel123456 for inconvenience.