Plots2: Success sign when Password match with Confirmation password

[avsingh999]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Please describe the problem (or idea)

This is a feature request in Sign up (https://publiclab.org/register) Page when we sign up and fill details but No success message sign when confirming password field and password filed match and no error sign when not match

It should look like this

EDIT:

Let's do form validation for the whole sign-up form, so you need to check username, email, password, password_confirmation for their presence and their format.

After that, if all the conditions are satisfied then user would be able to submit successfully otherwise sign-up button would just change the focus to error field. Any question?

[jywarren]

cool... is there a library that can help us do this?

On Mon, Sep 24, 2018 at 5:05 PM Avkaran Singh [e-mail]
wrote:

Please describe the problem (or idea)

This is a feature request in Sign Page when we sign up and fill details
but No success message sign when confirming password field and password
filed match and no error sign when not match
It's should look like this

What happened just before the problem occurred? Or what problem could this
idea solve?

What did you expect to see that you didn't?

[image: pssword]
https://user-images.githubusercontent.com/25536022/45979066-80383100-c06b-11e8-98d7-e99f4219700f.png
rg/ ...
Please show us where to look

https://publiclab.org/register
What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and
reproduce what you're seeing!

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping
refine and improve this site.

To learn how to write really great issues, which increases the chances
they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3439, or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2GEaOf4OFbnqRPs3zIqRpKvX_fFks5ueUkDgaJpZM4W3dLR
.

[SidharthBansal]

@avsingh999 please tell the hint to the solution so that I can post it on the GCI dashboard. We need to help the folks by giving them hints to libraries, etc. They are very young.
I hope you will understand and post it soon.

[kevinzluo]

Hi. I don't yet see this on the GCI dashboard, but I would like to do it.

[SidharthBansal]

Go ahead. I have made an issue for this. Please claim that before anyone else claims it.
https://codein.withgoogle.com/dashboard/tasks/6593856700153856/

[SidharthBansal]

If you find more such issues labelled with gci tag but are not part of gci platform please tell us. We will be happy to add them there too.
Thanks

[HarimAhmed]

hahaaa @SidharthBansal claimed it b4 😂

[kevinzluo]

Haha.
I could not have claimed it anyway since my previous task has not been approved.

[oorjitchowdhary]

@publiclab/reviewers This task is done or not? Coz I can still find it in the task listings in GCI

[grvsachdeva]

Do you see it open?

[oorjitchowdhary]

Yes

[grvsachdeva]

The task on GCI dashboard is duplicate. This issue is currently worked on by @kevinzluo. It would be closed soon. Thanks for notifying,

[oorjitchowdhary]

Okay great. Happy to help. 😄

[CodeSarthak]

Hey @jywarren @SidharthBansal It is still present on GCI, it would be good if it is removed to avoid confusion. Thanks 👍

[jywarren]

Hmm, i couldn't figure out to delete it, but I made its instance count zero.

[SidharthBansal]

I also could not find any way to delete. I hope decreasing instance count to zero works.

[SidharthBansal]

@kevinzluo is working on this.

[SidharthBansal]

Published for 2020 GCI

[VladimirMikulic]

@SidharthBansal I see that you are using the terms signup form and signup modal.
In the demo video is it the signup modal or form?
I understand modal as a popup and form as HTML form element ie. form that the user fills in that is in signup modal.

This PR, as you saw in the demo does form validation in the signup modal(it validates passwords as well as other inputs).

I hope we understand each other :smile:
Thanks a lot.

[SidharthBansal]

I agree with modal and form definitions

On Thu, 2 Jan 2020, 11:53 pm Vladimir Mikulic, [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal I see that you are
using the terms signup form and signup modal.
In the demo video is it the signup modal or form?
I understand modal as a popup and form as HTML form element ie. form that
the user fills in that is in signup modal.

This PR, as you saw in the demo does form validation in the signup
modal(it validates passwords as well as other inputs).

I hope we understand each other 😄
Thanks a lot.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3439?email_source=notifications&email_token=AFAAEQ7AASZUTC5PAHCMBJTQ3YWJ5A5CNFSM4FW52LI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7AJYY#issuecomment-570295523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ3CXECWEVBXT44YGBTQ3YWJ5ANCNFSM4FW52LIQ
.

[SidharthBansal]

That means you did both of them in the same pr? Great

On Fri, 3 Jan 2020, 12:06 am Sidharth Bansal, [e-mail]
wrote:

I agree with modal and form definitions

On Thu, 2 Jan 2020, 11:53 pm Vladimir Mikulic, [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal I see that you are
using the terms signup form and signup modal.
In the demo video is it the signup modal or form?
I understand modal as a popup and form as HTML form element ie. form that
the user fills in that is in signup modal.

This PR, as you saw in the demo does form validation in the signup
modal(it validates passwords as well as other inputs).

I hope we understand each other 😄
Thanks a lot.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3439?email_source=notifications&email_token=AFAAEQ7AASZUTC5PAHCMBJTQ3YWJ5A5CNFSM4FW52LI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7AJYY#issuecomment-570295523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ3CXECWEVBXT44YGBTQ3YWJ5ANCNFSM4FW52LIQ
.

[SidharthBansal]

Ques1: does that pr work for sign up modal?
Ques 2: does it work for signup form?
Ques 3: have you implemented password confirmation for both modal and form?

On Fri, 3 Jan 2020, 12:07 am Sidharth Bansal, [e-mail]
wrote:

That means you did both of them in the same pr? Great

On Fri, 3 Jan 2020, 12:06 am Sidharth Bansal, <
[email protected]> wrote:

I agree with modal and form definitions

On Thu, 2 Jan 2020, 11:53 pm Vladimir Mikulic, [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal I see that you are
using the terms signup form and signup modal.
In the demo video is it the signup modal or form?
I understand modal as a popup and form as HTML form element ie. form
that the user fills in that is in signup modal.

This PR, as you saw in the demo does form validation in the signup
modal(it validates passwords as well as other inputs).

I hope we understand each other 😄
Thanks a lot.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3439?email_source=notifications&email_token=AFAAEQ7AASZUTC5PAHCMBJTQ3YWJ5A5CNFSM4FW52LI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7AJYY#issuecomment-570295523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ3CXECWEVBXT44YGBTQ3YWJ5ANCNFSM4FW52LIQ
.

[VladimirMikulic]

@SidharthBansal my PR has all 3 quests done.

You mentioned 4 JS/RoR concrete tasks.

My PR covers the first two because it handles signup modal validation and signup form validation.

The only thing left to do here are login modal and login form validation. Login functionality is always handled on server, so RoR definitely.

[VladimirMikulic]

My PR also closes #4268. You can open a new issue for login modal and login form validation.

[SidharthBansal]

I think it should be 10 points in total. So you can claim this task and the
other task and get points. Both are hard tasks.
I hope you are ok with it.
Thanks

On Fri, 3 Jan 2020, 10:30 am Sidharth Bansal, [e-mail]
wrote:

Sure. I think we should make it as a single task having x points as one pr
is required. What should be x?

On Fri, 3 Jan 2020, 8:26 am Vladimir Mikulic, [e-mail]
wrote:

My PR also closes #4268 https://github.com/publiclab/plots2/issues/4268.
You can open a new issue for login modal and login form validation.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3439?email_source=notifications&email_token=AFAAEQZAJPWCLCWNRVT7K7TQ32SOHA5CNFSM4FW52LI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAELWQ#issuecomment-570443226,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ54ZJGC4JKVEBLDS4DQ32SOHANCNFSM4FW52LIQ
.

[SidharthBansal]

Explicitly: 5 points for #3439 issue and 5 points for #4268
This will be a fair judgment. So, in total 10 points. Is it okay with you?

[VladimirMikulic]

@SidharthBansal perfectly OK. Thank you for acknowledging my work :+1:

[SidharthBansal]

In case you find anywhere anyone is gettung lesser points then contact
me(including you).

On Fri, 3 Jan 2020, 3:14 pm Vladimir Mikulic, [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal perfectly OK. Thank
you for acknowledging my work 👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3439?email_source=notifications&email_token=AFAAEQ4A6OIB7W2HFVX637DQ34CJXA5CNFSM4FW52LI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAXF6I#issuecomment-570520313,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ4ASDC3T3CZFCXYPPLQ34CJXANCNFSM4FW52LIQ
.