Plots2: Sign-up Form Validation message correction

[grvsachdeva]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Problem

When a user tries to submit an empty sign up form, and also does not check off the recaptcha box, This output is shown:

Solution

Instead, we want all the relevant errors ("field cannot be empty" or so) to be listed along with the failed recaptcha verification.

Each box in this problem is worth some points. We will accept answers that complete one part and not the other, but encourage you to go for all 3. Completion of all three will result in bonus points :)

• [ ] fix the create action so that the correct errors show
• [ ] fix the error messages themselves as well. If you see below, there are three different errors for email, but only one of them is correct.
• [ ] write a test reflecting this fix. Guidelines: the test must fail without your changes, and your changes are what makes it pass.

[grvsachdeva]

Hi, this issue has been opened as a task on GCI dashboard. If you are Google Code-In participant and want to solve this issue, please claim it from Google Code-In website . Thanks!

[venkateshdb]

At first I was getting error while installing libv8 gem but with the help from @gauravano , I managed to install it but after that , This was the error I was getting while installing therubyracer gem.

[jywarren]

Hi, for some of these, we have it set up to behave differently in
production versus locally on a development setup. I think you're seeing
this difference, and if you start it in production mode (or make temporary
changes to the templates and controllers) you can "trick" it into showing
the full version. You may also be able to use the unstable build server
to test this, although it'll be pretty slow. I hope this helps!

On Sun, Nov 4, 2018 at 6:39 AM raddhika [e-mail] wrote:

not able to reproduce the exact copy of the origin
the "reCAPTCHA verification failed, please try again" won't load
also, sign up with google,twitter, etc. wont show up
[image: screen shot 2018-11-04 at 5 07 32 pm]
https://user-images.githubusercontent.com/44643389/47963588-35d7a600-e054-11e8-8227-8b4ed5e86f72.png
[image: screen shot 2018-11-04 at 5 07 48 pm]
https://user-images.githubusercontent.com/44643389/47963590-3c661d80-e054-11e8-88ee-5b0b76b639b7.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3340#issuecomment-435662331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ9H-9vISP9J8TV4FiRB7llvfbNnQks5urtG3gaJpZM4WrCAe
.

[SidharthBansal]

@Dsxv you can try to debug it. You were looking for some issues to be tackled and finding difficult to find easy ones, so helping you.

[Dsxv]

@SidharthBansal Thanks for Help ! How about we disable the submit button until the mandatory fields are completed ?

[SidharthBansal]

Good idea. Go for it.

On Thu, Jan 10, 2019, 11:30 PM Pawan Shukla <[email protected] wrote:

@SidharthBansal https://github.com/SidharthBansal Thanks for Help ! How
about we disable the submit button until the mandatory fields are completed
?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3340#issuecomment-453193304,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ1sMh9Mjcw8Wvrxj46uW6aOcNiCmks5vB3_PgaJpZM4WrCAe
.

[ananyaarun]

@gauravano , i recently worked on login form validation can i work on this ? Adding a required field to this will ensure a null form is not submitted .

[grvsachdeva]

Go ahead @ananyaarun! Thanks :+1:

[SidharthBansal]

Yeah sure

On Sat, Mar 16, 2019, 3:27 PM Ananya Arun [e-mail] wrote:

@gauravano https://github.com/gauravano , i recently worked on login
form validation can i work on this ? Adding a required field to this will
ensure a null form is not submitted .

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3340#issuecomment-473516627,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ8bvdSRU_JC6eAEQqyym700N1bwIks5vXMALgaJpZM4WrCAe
.

[sashadev-sky]

@SidharthBansal @gauravano I thought I was cleaning the issue by deleting comments but it makes it look so cluttered still!! Noted

[sashadev-sky]

@SidharthBansal @gauravano we need to add code links here. Since you opened the original issue @gauravano would you be able to figure out where the changes need to be made? The old link you provided is not a valid link anymore!

[SidharthBansal]

Sasha it will be great if you can open up a new issue and close this one.
We don't want misunderstanding for Gci candidates.

On Fri, Sep 13, 2019, 8:47 AM Sasha Boginsky [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal @gauravano
https://github.com/gauravano we need to add code links here. Since you
opened the original issue @gauravano https://github.com/gauravano would
you be able to figure out where the changes need to be made? The old link
you provided is not a valid link anymore!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3340?email_source=notifications&email_token=AFAAEQ5ENSLIMLHJ2NUR63LQJMA4XA5CNFSM4FVMEAPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6T26BY#issuecomment-531083015,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFAAEQY37V6SD5367GFHYN3QJMA4XANCNFSM4FVMEAPA
.

[sashadev-sky]

Ok if we want to keep it can either you or @gauravano please re-open with code links :)

[SidharthBansal]

Moved to #6303
@sashadev-sky it will be great if you use hide feature instead of delete feature.
Thanks for help!