Plots2: Add range buttons to /tag/____ page

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

We have a nice way of displaying activity on a topic for just a given time period: https://publiclab.org/tag/data-logging?start=16-03-2016&end=14-04-2017 (from #2439) --

...but no easy way to get to such a range-limited page from the basic page of https://publiclab.org/tag/data-logging. So this adds some nice buttons!

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/tag/show.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -51,7 +51,11 @@
   <% end %>

   <h3><% unless @tags.try(:first).try(:parent).nil? %><small>parent: <%= @tags.first.parent %></small><% end %></h3>
-  <%= render :partial => "notes/format_toggle" if @node_type == "note" %>
+  
+  <div class="btn-group visible-desktop" style="float:right;" id="note-format">
+    <a class="btn btn-default btn-sm" href="?start=<%= (@start || Time.now - 1.month).to_formatted_s(:long) %>&end=<%= (@end || Time.now).to_formatted_s(:long) %>">month</a>
+    <a class="btn btn-default btn-sm" href="?start=<%= (@start || Time.now - 1.year).to_formatted_s(:long) %>&end=<%= (@end || Time.now).to_formatted_s(:long) %>">year</a>
+  </div>

   <% if current_user %>
   <!-- AJAXify -->

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[yangmichaelkcs]

Can I try this?

[AmanGarg97]

Hey! I made a PR for this issue ( PR #3300 ).Please review this. Thanks!

[yash98gupta]

can i try ? i am new to open source

[jywarren]

Hi Yash, it looks like there's already a start to this one.
@publiclab/reviewers does anyone have a new FTO issue to share for Yash?

On Sat, Sep 8, 2018, 1:31 PM Yash [e-mail] wrote:

can i try ? i am new to open source

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3298#issuecomment-419659708,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ3pQD3j4dcy_i-TnWer0gtDOJQ2yks5uY_6ygaJpZM4Wbzwt
.

[Paarmita]

@jywarren Is this issue still open to work on?

[jywarren]

Hi, it looks like @AmanGarg97 is working on it in #3347 - but having some trouble. If you could test their code and upload a screenshot that'd be very helpful - and if you can help them figure out their install issues we'd also be grateful!

[sk9331657]

@publiclab/reviewers Please assign me a fto . Please

[agam-kashyap]

Hi, I would like to work on this issue if it is still open.
Thank you.

[jywarren]

I believe it's being worked on still in:

https://github.com/publiclab/plots2/pull/3347

I'm sure they'd love some help if you want to leave a comment there!

[jywarren]

Hi @sk9331657 - have you completed a FTO already? If not we're happy to make one for you!

[meinou]

🙋

[alonpeer]

Hi 👋
Is this issue still open, or was it resolved in PR #4103 ?

[grvsachdeva]

Hey @alonpeer, the issue is still available to claim. #4103 seems unrelated to this issue and @meinou opened PR against their own repo.

Let's just check with @meinou once, if they are interested in raising PR in this repo, as they have already done the work. Thanks!

[grvsachdeva]

Hey @alonpeer, have you started working on this issue?

[z119]

Is this issues still open? If so, i m interested in claiming it

[alonpeer]

Hi @z119, I believe this issue is still open. Go ahead!

[grvsachdeva]

@z119 as you have started working on another FTO, I am reassigning it to someone else. Thanks!

[grvsachdeva]

Hi @Devdrod, you can work on this FTO, if interested. Thanks!

[Linda-Ikechukwu]

Hi, has this issue been resolved, Can I work on it? I'm an outreachy intern applicant

[jywarren]

Hi, yes please! I believe @meinou's solution works, but it may need to be re-integrated into the new tag page template. You can find their code here, and if you'd like to build on that solution but in the new template, that's great! Thank you!

https://github.com/meinou/plots2/pull/1/files

[mhtien]

Hi, yes please! I believe @meinou's solution works, but it may need to be re-integrated into the new tag page template. You can find their code here, and if you'd like to build on that solution but in the new template, that's great! Thank you!

https://github.com/meinou/plots2/pull/1/files

Hi, just to let you know that @avats-dev has suggested I can attempt this 😄 hope that's ok!

[jywarren]

Hi! That's great! I wanted to suggest we could add a divider below the options in the Sort by dropdown, and put these Range options at the bottom of the dropdown?

That dropdown can be found here! https://github.com/publiclab/plots2/blob/main/app/views/tag/show/_sort.html.erb

[mhtien]

Hi! That's great! I wanted to suggest we could add a divider below the options in the Sort by dropdown, and put these Range options at the bottom of the dropdown?

That dropdown can be found here! https://github.com/publiclab/plots2/blob/main/app/views/tag/show/_sort.html.erb

Hey @jywarren ! This sounds like a cool idea! Could I get some clarification on what the range options are meant to show? Should the range options in the drop down be 'by month' and 'by year' (see below screenshot). If they click on one of them, does it filter the results per page? Or is it only meant to shown the time range of whats on the results. Thank you 😃

[jywarren]

Hi @mhtien - see how the links provided above:

+ <a class="btn btn-default btn-sm" href="?start=<%= (@start || Time.now - 1.month).to_formatted_s(:long) %>&end=<%= (@end || Time.now).to_formatted_s(:long) %>">month</a>

include time ranges? The routes to do this already exist, actually:

https://publiclab.org/tag/water-quality?start=01-12-2019&end=20-08-2020

I think perhaps the text of the links should say, "from the past year" and "from the past month" instead? Or, you could use a divider and header to show something like:

https://getbootstrap.com/docs/4.4/components/dropdowns/#headers

----
**Filter by date**
past year
past month

We can add more sophistication to the filter UI later, but this gives some initial links to narrow the range with. Make sense? Thank you!!!