Plots2: Adding Link to mark comment as spam to Dashboard Comment display

Created on 12 Aug 2018  路  6Comments  路  Source: publiclab/plots2

Add the comment moderation link <a href="/admin/mark_comment_spam/<%= @comment.id %>">Spam</a> with icon to comment view on dashboard.

demo

Like above comment notification on the dashboard is showing 3 comments as a link, we like to have a link (may be adjacent to it ) to mark the notified comment as spam.

Here's the file where change is required https://github.com/publiclab/plots2/blob/master/app/views/dashboard/_node_comment.html.erb

This would close https://github.com/publiclab/plots2/issues/3183 completing it. Thanks!

Ruby fto-candidate help wanted

Most helpful comment

Just to be clear it was just a friendly suggestion and not much of big concern, I advise people to follow because it eases the whole process for future PRs and all. Let's walk through the checklist and see how following it is beneficial:

  • [x] tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test ------ > This step lets one know that whether change done by him/her is giving any error or not. But, one can skip this step as running test locally most of the time gives error due to some additional integrations in production testing

  • [x] code is in a uniquely-named feature branch and has no merge conflicts ----- > Your last PR was on the master, and that can irritate you in future so creating a new branch and then raising PR can ease the task

  • [x] PR is descriptively titled ---> This one is just for clarity

  • [x] PR body includes fixes #0000-style reference to original issue # ----- > This automatically closes the issue number mentioned

  • [x] ask @publiclab/reviewers for help, in a comment below ---- > For asking for the review

These are just suggestions (from my little experience) and you are free to avoid them too. Your last PR was awesome :100: and you really helped a lot! Thanks @qm3 !

All 6 comments

Hey, @qm3 you might be interested in solving this. Thanks!

@gauravano I will take a look at it. Thanks for giving me this issue!

Hi @gauravano, in the last issue you suggested that I read the checklist of PR body and reflect the changes in raising PR process. Did you mean that I should comment under the PR checklist body and comment about those changes? Thanks!

Just to be clear it was just a friendly suggestion and not much of big concern, I advise people to follow because it eases the whole process for future PRs and all. Let's walk through the checklist and see how following it is beneficial:

  • [x] tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test ------ > This step lets one know that whether change done by him/her is giving any error or not. But, one can skip this step as running test locally most of the time gives error due to some additional integrations in production testing

  • [x] code is in a uniquely-named feature branch and has no merge conflicts ----- > Your last PR was on the master, and that can irritate you in future so creating a new branch and then raising PR can ease the task

  • [x] PR is descriptively titled ---> This one is just for clarity

  • [x] PR body includes fixes #0000-style reference to original issue # ----- > This automatically closes the issue number mentioned

  • [x] ask @publiclab/reviewers for help, in a comment below ---- > For asking for the review

These are just suggestions (from my little experience) and you are free to avoid them too. Your last PR was awesome :100: and you really helped a lot! Thanks @qm3 !

I have also added the link to the file where change is required, feel free to ask if there is any doubt. Thanks!

Hi @gauravano @jywarren is this issue solved?
If no we can make this for gci

Was this page helpful?
0 / 5 - 0 ratings

Related issues

grvsachdeva picture grvsachdeva  路  3Comments

jywarren picture jywarren  路  3Comments

milaaraujo picture milaaraujo  路  3Comments

divyabaid16 picture divyabaid16  路  3Comments

grvsachdeva picture grvsachdeva  路  3Comments