Plots2: Trending tags showing duplicates

[jywarren]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

I think we're missing a group() or something on the https://publiclab.org/dashboard's trending tags area - i'm seeing 5 of the same:

Here's the code -

https://github.com/publiclab/plots2/blob/0663ac5f7ad7d047fc47e2b5b9ae59c943f354bc/app/models/tag.rb#L268-L277

And here's the test, where i'm not sure but maybe we should test to be sure they're unique?

https://github.com/publiclab/plots2/blob/ceb7d05404b4619c7fa8cd8cae5e8215798cb02c/test/unit/tag_test.rb#L131-L137

Any help appreciated!

[SidharthBansal]

This task is published on GCI dashboard. Thanks all.

[vatbq]

I just have one question, How I send you the task ready? Do I have to do a pull request in repository or what? thanks!

[grvsachdeva]

Hi @ValentinaTironi , this task is reserved for Google Code-In students, have you claimed this task from GCI website?

[vatbq]

@gauravano Hi, thanks for answer. Yes, I did. I arrived here for the task

[grvsachdeva]

Awesome! You have to open the Pull request with your changes. Thanks!

[vatbq]

Hi! I'm trying to do a git push to do a pull request here but it says that I don't have permission. What I have to do?

[geekychasser]

@ValentinaTironi You need to do git push to your forked repository and then create a pull request.
Good luck!

[jywarren]

so that would be something like git push [email protected]:ValentinaTironi/plots2 feature-branch-name or possibly git push https://github.com/ValentinaTironi/plots2 feature-branch-name

ask if you need help, we're happy to support!

On Tue, Nov 13, 2018 at 8:07 AM Rishabh [e-mail] wrote:

@ValentinaTironi https://github.com/ValentinaTironi You need to do git
push to your forked repository and then create a pull request.
Good luck!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3188#issuecomment-438259007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2AWhBvTj3QVzFBOh1dfRACT9G3Hks5uusPXgaJpZM4VsoDp
.

[geekychasser]

@ValentinaTironi It seems like you have not forked the repository. So to get started follow these installation process https://github.com/publiclab/plots2#installation

[jywarren]

This didn't end up solving the issue, unfortunately! Reopening to see if we can develop another solution.

[vatbq]

Oh, sorry. Tell me if I can help in something :/

[milaaraujo]

I'll work on this one.

[jywarren]

awesome!

On Sat, Dec 8, 2018 at 12:33 AM Camila Araújo [e-mail]
wrote:

I'll work on this one.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/3188#issuecomment-445436139,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ9Ptr3AXZAw0oHxpPBCrPSoJYkUQks5u2103gaJpZM4VsoDp
.