Plots2: Merge commenting/answering interfaces to reduce redundancy

Created on 22 Jun 2018  路  2Comments  路  Source: publiclab/plots2

and make the code more maintainable! This will also bring the new comment emoji system to Questions and Answers.

The basic comment form is here:

https://github.com/publiclab/plots2/blob/master/app/views/comments/_form.html.erb

But Questions have their own style comments. It's cool, but I think we should merge these for consistent UI and easier maintenance:

https://github.com/publiclab/plots2/blob/master/app/views/questions/_comment.html.erb

the form itself here: https://github.com/publiclab/plots2/blob/master/app/views/questions/_form.html.erb

Also, Answers have their own editor. I feel like it could also just be the same editor. But maybe it already does?

https://github.com/publiclab/plots2/blob/master/app/views/questions/_answers.html.erb#L11

There are also various JavaScripts that'll have to be detangled or made consistent, in https://github.com/publiclab/plots2/blob/master/app/assets/javascripts/

Any help appreciated!

HTML JavaScript Ruby break-me-up design help wanted

Most helpful comment

Sure, I'd be happy to give this a go!!

All 2 comments

@viditchitkara I wonder if you'd be interested in this one? It'd make your new awesome emoji work present in question pages. :tada:

Sure, I'd be happy to give this a go!!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

grvsachdeva picture grvsachdeva  路  3Comments

grvsachdeva picture grvsachdeva  路  3Comments

first-timers[bot] picture first-timers[bot]  路  3Comments

shapironick picture shapironick  路  3Comments

first-timers[bot] picture first-timers[bot]  路  3Comments