Plots2: Create Github OAuth App

[SidharthBansal]

Github settings as given on https://www.natashatherobot.com/rails-omniauth-github-tutorial/ are functional as tested in test app.



We need to verify that the following will work properly for all users:

• [x] localhost:3000/auth/github
• [x] localhost:3001/auth/github
• [x] unstable.publiclab.org/auth/github
• [x] stable.publiclab.org/auth/github
• [x] publiclab.org/auth/github

[SidharthBansal]

@jywarren this needs to be done after #2771 is merged and google works perfectly in production.

[SidharthBansal]

Part of #2676

[jywarren]

Hi, this looks great. Can you create an "Oauth Login" milestone and add and prioritize things in there? I think it'll be helpful to keep track. Thanks!!!

[SidharthBansal]

I have created #2676 as main issue for the milestone OAUTH LOGIN. I have written each and every needy greedy detail of all the linked issues. I hope this will reduce the ambiguity which we are facing nowadays.

[jywarren]

:-) awesome!!!

[SidharthBansal]

I am done with github provider. Whenever you get time you can make github app.
Thanks

[jywarren]

OK, so i should make multiple apps, one for each environment, like localhost:3000, stable, unstable...?

[jywarren]

And what env variable name should I use? OAUTH_GITHUB_APP_KEY and OAUTH_GITHUB_APP_SECRET?

[SidharthBansal]

Yeah.

[jywarren]

Are the localhost ones really necessary? Could people build those themselves?

[jywarren]

The others are done and installed on Jenkins and production though!

[SidharthBansal]

localhost ones can be made by developers.

[SidharthBansal]

The others are done and installed on Jenkins and production though!

Have you completed the github developer apps settings?

[SidharthBansal]

But the feature will not be present in localhost. Developers will not be able to login and logout via providers

[jywarren]

Yes i think so!

[SidharthBansal]

No they are not.
@jywarren this is Github issue. I think you are talking about #2892.

The link stable.publiclab.org/auth/github is not functional

[SidharthBansal]

Can we first finish up #2892 and then jump into this?

[jywarren]

No, i just set it all up for GitHub going through the steps above. But I haven't pushed to stable since this morning; i can now.

[SidharthBansal]

Ok. Let's push there and see.

[SidharthBansal]

Hurray

It is working fine on stable

[SidharthBansal]

@jywarren I guess you wrote your name instead of Public lab.
Github asks to sign in jywarren instead of public lab.
Can you please change that?
Thanks

[SidharthBansal]

Great. Now the text is stable.publiclab.org

[jywarren]

OK pushed! testing

[jywarren]

it works!

[jywarren]

Ah oops!

[jywarren]

how about now?

[SidharthBansal]

stable working fine
unstable bad gateway error
pl.org not functional

[jywarren]

It's not published to production yet -- and not to unstable, but you can push it there!

[jywarren]

publishing to production now

[SidharthBansal]

Pushed to unstable
Testing now

[SidharthBansal]

Unstable shows 502 Bad Gateway

[SidharthBansal]

We are done with unstable
Thanks @jywarren

[SidharthBansal]

We are done with PL.org
Thanks a lot @jywarren

[SidharthBansal]

Now we are back to localhost:3000 and localhost:3001.
What do we need to do for them?
I will suggest that the developer should create their account themselves OR we can make an app for the developer. Here we don't have to do any domain verificationas we did in case of Google. So, this will be pretty simple.

[jywarren]

Let's for the time being ask the developer to do it for themselves. I think
that's reasonable -- if we find we need to do a lot more work on them,
maybe we can change our minds. What do you think?

But we can also provide documentation for how to set it up.

[jywarren]

yep that's how unstable works. Super!

[SidharthBansal]

I think let's try and make at least one developer's app, say GitHub. So that the developers will have an ease with logging in and logging out
We can set up documentation for other providers.
Creating 4 developers app and changing the settings each time the provider changes its setting will be a tough job for you. You already need to change the settings for 3 apps unstable, stable and production if any settings change for an provider.

[SidharthBansal]

And
THANKS A LOT for making 3 apps for GitHub provider.

[jywarren]

I like this idea! OK -- so, should we openly share the app id then?

[jywarren]

and the secret? I have a localhost:3000 one ready

[SidharthBansal]

Can you check if jenkins development environment variables can work?
If they can work then it would be best.

[SidharthBansal]

I mean set up the environment variables for development too as you set up for production. Then we can test.

[jywarren]

Oh, but we run Jenkins builds in production environment. Ah, you mean temporarily replace them and test it out? Sure, i can do that tomorrow morning. But how would we help people use them locally?

[SidharthBansal]

and the secret?

Sorry you cannot send your app_secret to anyone. I sent you because I can trust you. And I will delete the app in a week or two when we will finish up with Google completely. But you cannot trust on the new developers

[SidharthBansal]

I was refering to the way you wrote in https://github.com/publiclab/plots2/pull/2855#issuecomment-398864238

[jywarren]

That's fine, i just am not sure for whom we are setting up the developer app... are we just testing that it works at all? If we're not distributing a secret key, folks won't be able to try it locally. Sorry if I'm missing something really obvious here!

[SidharthBansal]

for whom we are setting up the developer app... are we just testing that it works at all?

For the future developers maybe after 3-4 years who will need to change the authentication system for its improvement. I am concerned about future.

Secondly, the developers will be able to log in and log out via localhost:3000 via providers. Otherwise when new developers will try to login via provider they will get errors and they will report them as issues on public lab.

[SidharthBansal]

If we're not distributing a secret key, folks won't be able to try it locally.

They can try it on localhost only if they make their own developer's app. Else they will get errors. I am concerned about those errors.

[SidharthBansal]

Errors like missing client_id etc. when they will try to log in via provider.

The existing login system (username and password) will work on the localhost too for them.

[jywarren]

Ah, so you would just like to debug the errors one gets when doing this
from localhost?

On Tue, Jun 26, 2018 at 7:55 PM Sidharth Bansal [e-mail]
wrote:

Errors like missing client_id etc. when they will try to log in via
provider.

The existing login system will work on the localhost too for them.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2856#issuecomment-400499091,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ1ybdTZ6oDlEqQdOJ0XlXwa8slR_ks5uAsnpgaJpZM4UtlK7
.

[SidharthBansal]

Yes.

[SidharthBansal]

One way is to use <% if Rails.env == "production"%> for the views. This will not let the developers sign in via provider until they go to localhost:xxxx/auth/:provider. And write documentation for setting up app.
What do you say?