Plots2: Tag pages have non-standard headers on each tab

[ebarry]

Please describe the problem (or idea)

What happened just before the problem occurred?

It's really great to have a direct link to all the Contributors to a tag, but the contributor tab on Tag Pages is missing the standard header that is present on other tabs of the tag page. See below GIF:

Notice that all tabs on the Tag Page have the same header EXCEPT for the Contributors tab. Here's what's different:

• sidebar is present on the Contributors tab (the other tabs don't have it)
• there is no Wiki Preview and "Read More" link at the top of the page, instead the graph is the topmost item on the page
• the tab structure itself is missing, thwarting attempts to navigate back to the main Tag Page from Contributors Tab, ESPECIALLY when arriving at the Contributors Tab via a direct link.

-

What did you expect to see that you didn't?

• no sidebar
• standard header with other tabs on Tag Page
• presence of Tabs for navigation through the entire Tag Page

Please show us where to look

https://publiclab.org/contributors/pm

What's your PublicLab.org username?

This can help us diagnose the issue: liz

[ebarry]

Oh! i believe @Gauravano fixed this back in January! Scroll down to the bottom of https://github.com/publiclab/plots2/commits/master/app/views/tag/_contributors.html.erb -- can we bring this back?

[ebarry]

OMG @jywarren just found out what was up with this:

There are two pages:

• https://publiclab.org/contributors/tag/balloon-mapping -- already working perfectly!!!!
• https://publiclab.org/contributors/balloon-mapping -- the old style that every tag page links to in the tab, that i filed this issue about!

@jywarren please advise on this :)

[jywarren]

Let's merge the best parts of each, and have /contributors/tag/_____
redirect to /contributors/_______ in config/routes.rb --

Things to preserve:

• tabs
• nice 3-panel "stats"
• nice new graph
• no sidebar
• preview of wiki page and 'Read more' at top

Anything else?

On Fri, May 11, 2018 at 1:58 PM, Liz Barry [e-mail] wrote:

OMG @jywarren https://github.com/jywarren just found out what was up
with this:

There are two pages:

• https://publiclab.org/contributors/tag/balloon-mapping -- already
  working perfectly!!!!
• https://publiclab.org/contributors/balloon-mapping -- the old style
  that every tag page links to in the tab, that i filed this issue about!

@jywarren https://github.com/jywarren please advise on this :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2718#issuecomment-388439382,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ3IU-YPdSgAqMvunsQxqksQwJV9Cks5txdFVgaJpZM4T7cq8
.

[jywarren]

so, https://publiclab.org/contributors/tag/balloon-mapping is driven by the def show method in this file:

https://github.com/publiclab/plots2/blob/7896dfa2fab442088022400fb676aae289a120f4/app/controllers/tag_controller.rb#L92

Whereas https://publiclab.org/contributors/balloon-mapping is driven by this code:

https://github.com/publiclab/plots2/blob/7896dfa2fab442088022400fb676aae289a120f4/app/controllers/tag_controller.rb#L421-L427

The first one is great and we don't really need the second. Let's get rid of the 2nd one (https://publiclab.org/contributors/balloon-mapping), including:

• [ ] delete the def contributors method in tag_controller.rb
• [ ] delete the template at /app/views/tag/contributors.html.erb -- double check that the https://publiclab.org/contributors/tag/balloon-mapping still works!
• [ ] point the route (https://publiclab.org/contributors/balloon-mapping) in /config/routes.rb to the same action as https://publiclab.org/contributors/tag/balloon-mapping so they're two URLs to the same page

That should close out this issue!

[oorjitchowdhary]

Can I take this up?

[jywarren]

sure, yes please!

On Mon, Dec 10, 2018 at 3:35 AM Oorjit Chowdhary [e-mail]
wrote:

Can I take this up?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2718#issuecomment-445749834,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxIv821nPnkLemvvfQPfPGfY5yQIks5u3irYgaJpZM4T7cq8
.

[jywarren]

Closing and merging into https://github.com/publiclab/plots2/issues/6307 after the major tag page overhaul!