Plots2: Add a text "feature" instead of static text to /places page

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/notes/tools_places.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -20,15 +20,8 @@

 <div class="col-md-12">

-  <% if params[:action] == 'methods' %>
-    <div style="text-align:center;">
-      <h1 style="font-size:3.4em;margin-top:40px;"><%= raw t('notes.tools_places.tools_and_techniques') %></h1>
-      <h4 style="color:#888;"><%= raw t('notes.tools_places.subtitle') %></h4>
-      <p><i>Public Lab's community collaboratively develops many different techniques and methods for DIY environmental monitoring. Browse many of them here and learn how to get involved.</i></p>
-    </div>
-  <% else %>
-    <h2><%= t('notes.tools_places.public_lab_chapters') %> <small><%= raw t('notes.tools_places.start_a_chapter', :url1 => "/wiki/start-a-chapter") %></small></h2>
-  <% end %>
+  <%= feature('places') %>
+
   <hr />
   <% if params[:controller] == "notes" && (params[:action] == "popular" || params[:action] == "index" || params[:action] == "liked") %>
     <div class="navbar">

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[hyser521]

I'd like to take this project if that's alright.

[sagarpreet-chadha]

Hi @hyser521 ...that would be awesome ! :smile:
Feel free to ask here to @publiclab/reviewers team in case of any doubt .
Thanks !!

[hyser521]

I've set up my pull request, but when I tried to mention @publiclab/reviewers it didn't turn into a link. What am I doing incorrectly?

[jywarren]

Hmm I think that's something we're trying to figure out... I believe non
reviewers can't trigger it perhaps, which is too bad. Maybe we can create a
bit behavior to solve this though. Thanks! We'll review in the next day and
your help is much appreciated!!!

On Tue, Apr 17, 2018, 8:32 PM hyser521 [e-mail] wrote:

I've set up my pull request, but when I tried to mention
@publiclab/reviewers, it didn't turn into a link. What am I doing
incorrectly?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2629#issuecomment-382203090,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJxEibltqbsG6w8zlJ-3FqIGSWxhbks5tpoltgaJpZM4TYll1
.

[SidharthBansal]

I spotted the error. You need a space after @publiclab/reviewers else the link will not work. You have a comma instead of a space hence it is not working

[hyser521]

@SidharthBansal I don't think that did it- I edited my above comment and still did not get the mention. If I do it at the end of this comment with no punctuation near it as well, it still doesn't work.
@publiclab/reviewers

[SidharthBansal]

Yeah you can't trigger I checked by making a new account and then previewing the comment.
You can ping @sagarpreet-chadha @jywarren @Gauravano or me till we see what else can be done.
Thanks for reporting this.

[hyser521]

No problem, thanks for doing the due diligence to confirm my issue.