Plots2: Hide "stale page" notice for locked pages

Created on 16 Apr 2018  ยท  6Comments  ยท  Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you ๐Ÿ’

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

๐Ÿค” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This change removes the "stale page alert" from locked pages like http://publiclab.org/join, because those pages (being locked) are not going to be edited as often!

๐Ÿ“‹ Step by Step

  • [ ] ๐Ÿ™‹ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] ๐Ÿ“ Update the file app/views/wiki/show.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -21,7 +21,7 @@

 <div class="row">

-<% if @node.latest.created_at < Time.now - 6.months %>
+<% if [email protected]_tag('locked') && @node.latest.created_at < Time.now - 6.months %>
   <div class="alert alert-info" role="alert">This wiki page hasn't been edited for a while. If you see anything that needs updating, please help out!</div>
 <% end %>

  • [ ] ๐Ÿ’พ Commit your changes

  • [ ] ๐Ÿ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] ๐Ÿ Done Ask in comments for a review :)

๐Ÿค”โ“ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

first-timers-only help wanted

Most helpful comment

Hey, I think im finished.

All 6 comments

Hello. I would like to claim this :)

Awesome @StereotypicalCat :tada: :smiley:
If you want any help please feel free to mention @publiclab/reviewers, we would be happy to help.Thanks.

Hey @Gauravano or @publiclab/reviewers sorry to already ask for help already. Do i need to create a new branch for this to work? I am trying to look for it on plots2 -> branches, but it does not seem like I can.

Hey @Gauravano or @publiclab/reviewers sorry to already ask for help already.

No issue at all. yes, you need to create new branch for this on your local machine and then push it to your plots2 fork.

Hey, I think im finished.

Thanks a lot for the chance to try this out!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

grvsachdeva picture grvsachdeva  ยท  3Comments

keshavsethi picture keshavsethi  ยท  3Comments

jywarren picture jywarren  ยท  3Comments

bronwen9 picture bronwen9  ยท  3Comments

milaaraujo picture milaaraujo  ยท  3Comments