Plots2: Add a feedback notice to "i did this" buttons

Created on 12 Mar 2018  ยท  6Comments  ยท  Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you ๐Ÿ’

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

๐Ÿค” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This will add a helpful message next to the I did this button at the bottom of pages like this: https://publiclab.org/notes/SuziT9/03-08-2018/building-miniature-kites-at-a-family-science-night

๐Ÿ“‹ Step by Step

  • [ ] ๐Ÿ™‹ Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] ๐Ÿ“ Update the file app/views/notes/_responses.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -5,7 +5,7 @@
     <% @responses = Tag.find_nodes_by_type("#{response_type}:#{@node.id}", "note", 200) %>
     <% @unpaginated = true %>

-    <p id="<%= response_type %>s"><a class='btn btn-primary btn-lg' href="/post?tags=<%= response_type %>:<%= @node.id %><% if response_type == 'response' %>,hidden:response<% end %><%= ',' + (@tagnames.uniq.delete_if{|x| x.match(":") }).join(',') if @tagnames && @tagnames.length > 0 %>"><%= t('notes._responses.post_' + response_type) %></a>&nbsp;
+    <p id="<%= response_type %>s"><a class='btn btn-primary btn-lg' href="/post?tags=<%= response_type %>:<%= @node.id %><% if response_type == 'response' %>,hidden:response<% end %><%= ',' + (@tagnames.uniq.delete_if{|x| x.match(":") }).join(',') if @tagnames && @tagnames.length > 0 %>"><%= t('notes._responses.post_' + response_type) %></a> Help out by offering feedback!
       <% if @node.power_tag('activity') %>
         <% if Tag.where(name: 'activities:' + @node.power_tag('activity')).first %>
           <% if Tag.where(name: 'activities:' + @node.power_tag('activity')).first.nodes.length > 0 %>
  • [ ] ๐Ÿ’พ Commit your changes

  • [ ] ๐Ÿ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] ๐Ÿ Done Ask in comments for a review :)

๐Ÿค”โ“ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

HTML first-timers-only has-pull-request help wanted

Most helpful comment

who is working on this.? I'm a beginner and I like to solve this?

All 6 comments

who is working on this.? I'm a beginner and I like to solve this?

@SamithDB that would be awesome!!! Go ahead.

not sure if I can claim this, seems done but its still open.

is it open cause it has been merged....?

pls assign this issue to me...

Hi, i believe it's already done, see #2476 above. But there were just a few new first-timers issues posted at https://publiclab.github.io/community-toolbox/#r=all - give them a try!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

first-timers[bot] picture first-timers[bot]  ยท  3Comments

noi5e picture noi5e  ยท  3Comments

jywarren picture jywarren  ยท  3Comments

grvsachdeva picture grvsachdeva  ยท  3Comments

ebarry picture ebarry  ยท  3Comments